From: kernel test robot <lkp@intel.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kbuild-all@lists.01.org, Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Zeng Guang <guang.zeng@intel.com>, Chao Gao <chao.gao@intel.com>
Subject: Re: [PATCH 04/11] KVM: SVM: Use common kvm_apic_write_nodecode() for AVIC write traps
Date: Sat, 5 Feb 2022 07:14:58 +0800 [thread overview]
Message-ID: <202202050720.YPm113nN-lkp@intel.com> (raw)
In-Reply-To: <20220204214205.3306634-5-seanjc@google.com>
Hi Sean,
I love your patch! Yet something to improve:
[auto build test ERROR on 17179d0068b20413de2355f84c75a93740257e20]
url: https://github.com/0day-ci/linux/commits/Sean-Christopherson/KVM-x86-Prep-work-for-VMX-IPI-virtualization/20220205-054418
base: 17179d0068b20413de2355f84c75a93740257e20
config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20220205/202202050720.YPm113nN-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/528172fca9c0e8fac06680430bf69a55e4559974
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sean-Christopherson/KVM-x86-Prep-work-for-VMX-IPI-virtualization/20220205-054418
git checkout 528172fca9c0e8fac06680430bf69a55e4559974
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/kvm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/x86/kvm/svm/avic.c: In function 'avic_unaccel_trap_write':
>> arch/x86/kvm/svm/avic.c:486:35: error: 'svm' undeclared (first use in this function); did you mean 'sem'?
486 | if (avic_handle_apic_id_update(&svm->vcpu))
| ^~~
| sem
arch/x86/kvm/svm/avic.c:486:35: note: each undeclared identifier is reported only once for each function it appears in
vim +486 arch/x86/kvm/svm/avic.c
ef0f64960d012cb Joerg Roedel 2020-03-31 478
528172fca9c0e8f Sean Christopherson 2022-02-04 479 static int avic_unaccel_trap_write(struct kvm_vcpu *vcpu)
ef0f64960d012cb Joerg Roedel 2020-03-31 480 {
528172fca9c0e8f Sean Christopherson 2022-02-04 481 u32 offset = to_svm(vcpu)->vmcb->control.exit_info_1 &
ef0f64960d012cb Joerg Roedel 2020-03-31 482 AVIC_UNACCEL_ACCESS_OFFSET_MASK;
ef0f64960d012cb Joerg Roedel 2020-03-31 483
ef0f64960d012cb Joerg Roedel 2020-03-31 484 switch (offset) {
ef0f64960d012cb Joerg Roedel 2020-03-31 485 case APIC_ID:
ef0f64960d012cb Joerg Roedel 2020-03-31 @486 if (avic_handle_apic_id_update(&svm->vcpu))
ef0f64960d012cb Joerg Roedel 2020-03-31 487 return 0;
ef0f64960d012cb Joerg Roedel 2020-03-31 488 break;
ef0f64960d012cb Joerg Roedel 2020-03-31 489 case APIC_LDR:
528172fca9c0e8f Sean Christopherson 2022-02-04 490 if (avic_handle_ldr_update(vcpu))
ef0f64960d012cb Joerg Roedel 2020-03-31 491 return 0;
ef0f64960d012cb Joerg Roedel 2020-03-31 492 break;
ef0f64960d012cb Joerg Roedel 2020-03-31 493 case APIC_DFR:
528172fca9c0e8f Sean Christopherson 2022-02-04 494 avic_handle_dfr_update(vcpu);
ef0f64960d012cb Joerg Roedel 2020-03-31 495 break;
ef0f64960d012cb Joerg Roedel 2020-03-31 496 default:
ef0f64960d012cb Joerg Roedel 2020-03-31 497 break;
ef0f64960d012cb Joerg Roedel 2020-03-31 498 }
ef0f64960d012cb Joerg Roedel 2020-03-31 499
528172fca9c0e8f Sean Christopherson 2022-02-04 500 kvm_apic_write_nodecode(vcpu, offset);
ef0f64960d012cb Joerg Roedel 2020-03-31 501 return 1;
ef0f64960d012cb Joerg Roedel 2020-03-31 502 }
ef0f64960d012cb Joerg Roedel 2020-03-31 503
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-02-04 23:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 21:41 [PATCH 00/11] KVM: x86: Prep work for VMX IPI virtualization Sean Christopherson
2022-02-04 21:41 ` [PATCH 01/11] Revert "svm: Add warning message for AVIC IPI invalid target" Sean Christopherson
2022-02-07 16:44 ` Paolo Bonzini
2022-02-04 21:41 ` [PATCH 02/11] KVM: VMX: Handle APIC-write offset wrangling in VMX code Sean Christopherson
2022-02-15 2:22 ` Chao Gao
2022-02-15 16:30 ` Sean Christopherson
2022-02-04 21:41 ` [PATCH 03/11] KVM: x86: Use "raw" APIC register read for handling APIC-write VM-Exit Sean Christopherson
2022-02-04 21:41 ` [PATCH 04/11] KVM: SVM: Use common kvm_apic_write_nodecode() for AVIC write traps Sean Christopherson
2022-02-04 23:14 ` kernel test robot [this message]
2022-02-07 16:16 ` Sean Christopherson
2022-02-04 21:41 ` [PATCH 05/11] KVM: SVM: Don't rewrite guest ICR on AVIC IPI virtualization failure Sean Christopherson
2022-02-04 21:42 ` [PATCH 06/11] KVM: x86: WARN if KVM emulates an IPI without clearing the BUSY flag Sean Christopherson
2022-02-04 21:42 ` [PATCH 07/11] KVM: x86: Make kvm_lapic_reg_{read,write}() static Sean Christopherson
2022-02-04 21:42 ` [PATCH 08/11] KVM: x86: Add helpers to handle 64-bit APIC MSR read/writes Sean Christopherson
2022-02-04 21:42 ` [PATCH 09/11] KVM: x86: Treat x2APIC's ICR as a 64-bit register, not two 32-bit regs Sean Christopherson
2022-02-15 3:27 ` Chao Gao
2022-02-15 16:40 ` Sean Christopherson
2022-02-04 21:42 ` [PATCH 10/11] KVM: x86: Make kvm_lapic_set_reg() a "private" xAPIC helper Sean Christopherson
2022-02-04 21:42 ` [PATCH 11/11] KVM: selftests: Add test to verify KVM handles x2APIC ICR=>ICR2 dance Sean Christopherson
2022-02-24 14:58 ` [PATCH 00/11] KVM: x86: Prep work for VMX IPI virtualization Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202202050720.YPm113nN-lkp@intel.com \
--to=lkp@intel.com \
--cc=chao.gao@intel.com \
--cc=guang.zeng@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox