public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Nico Boehr <nrb@linux.ibm.com>
To: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com,
	david@redhat.com
Subject: [kvm-unit-tests PATCH v2 2/8] s390x: Add test for PFMF low-address protection
Date: Mon, 21 Feb 2022 14:07:40 +0100	[thread overview]
Message-ID: <20220221130746.1754410-3-nrb@linux.ibm.com> (raw)
In-Reply-To: <20220221130746.1754410-1-nrb@linux.ibm.com>

PFMF should respect the low-address protection when clearing pages, hence
add some tests for it.

When low-address protection fails, clearing frame 0 is a destructive
operation. It messes up interrupts and thus printing test results won't
work properly. Hence, we first attempt to clear frame 1 which is not as
destructive.

Doing it this way around increases the chances for the user to see a
proper failure message instead of QEMU randomly quitting in the middle
of the test run.

Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
 s390x/pfmf.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/s390x/pfmf.c b/s390x/pfmf.c
index 2f3cb110dc4c..aa1305292ee8 100644
--- a/s390x/pfmf.c
+++ b/s390x/pfmf.c
@@ -113,6 +113,34 @@ static void test_1m_clear(void)
 	report_prefix_pop();
 }
 
+static void test_low_addr_prot(void)
+{
+	union pfmf_r1 r1 = {
+		.reg.cf = 1,
+		.reg.fsc = PFMF_FSC_4K
+	};
+
+	report_prefix_push("low-address protection");
+
+	report_prefix_push("0x1000");
+	expect_pgm_int();
+	low_prot_enable();
+	pfmf(r1.val, (void *)0x1000);
+	low_prot_disable();
+	check_pgm_int_code(PGM_INT_CODE_PROTECTION);
+	report_prefix_pop();
+
+	report_prefix_push("0x0");
+	expect_pgm_int();
+	low_prot_enable();
+	pfmf(r1.val, 0);
+	low_prot_disable();
+	check_pgm_int_code(PGM_INT_CODE_PROTECTION);
+	report_prefix_pop();
+
+	report_prefix_pop();
+}
+
 int main(void)
 {
 	bool has_edat = test_facility(8);
@@ -124,6 +152,7 @@ int main(void)
 	}
 
 	test_priv();
+	test_low_addr_prot();
 	/* Force the buffer pages in */
 	memset(pagebuf, 0, PAGE_SIZE * 256);
 
-- 
2.31.1


  parent reply	other threads:[~2022-02-21 13:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 13:07 [kvm-unit-tests PATCH v2 0/8] s390x: Extend instruction interception tests Nico Boehr
2022-02-21 13:07 ` [kvm-unit-tests PATCH v2 1/8] s390x: Add more tests for MSCH Nico Boehr
2022-02-21 13:07 ` Nico Boehr [this message]
2022-02-21 13:07 ` [kvm-unit-tests PATCH v2 3/8] s390x: Add sck tests Nico Boehr
2022-02-21 13:07 ` [kvm-unit-tests PATCH v2 4/8] s390x: Add tests for STCRW Nico Boehr
2022-02-21 13:07 ` [kvm-unit-tests PATCH v2 5/8] s390x: Add more tests for SSCH Nico Boehr
2022-02-21 13:07 ` [kvm-unit-tests PATCH v2 6/8] s390x: Add more tests for STSCH Nico Boehr
2022-02-21 13:07 ` [kvm-unit-tests PATCH v2 7/8] s390x: Add tests for TSCH Nico Boehr
2022-02-21 13:07 ` [kvm-unit-tests PATCH v2 8/8] s390x: Add EPSW test Nico Boehr
2022-02-21 15:30 ` [kvm-unit-tests PATCH v2 0/8] s390x: Extend instruction interception tests Janosch Frank
2022-02-23  9:18   ` Nico Boehr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220221130746.1754410-3-nrb@linux.ibm.com \
    --to=nrb@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox