From: Kees Cook <keescook@chromium.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Shuah Khan <shuah@kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
kernel@collabora.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] kselftest: add generated objects to .gitignore
Date: Fri, 25 Feb 2022 18:23:26 -0800 [thread overview]
Message-ID: <202202251823.138A87C@keescook> (raw)
In-Reply-To: <f3757ff8-0078-4cf9-c0c6-95c780b90ae2@linuxfoundation.org>
On Fri, Feb 25, 2022 at 04:59:58PM -0700, Shuah Khan wrote:
> On 2/25/22 3:27 AM, Muhammad Usama Anjum wrote:
> > Add kselftests_install directory and some other files to the
> > .gitignore.
> >
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> > ---
> > tools/testing/selftests/.gitignore | 1 +
> > tools/testing/selftests/exec/.gitignore | 2 ++
> > tools/testing/selftests/kvm/.gitignore | 1 +
> > tools/testing/selftests/net/.gitignore | 1 +
> > 4 files changed, 5 insertions(+)
> >
>
> It is better to split these patches per test - makes it easier
> to apply. Please send separate patches for each test. This patch
> doesn't apply as is.
Once fixed, please consider them:
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2022-02-26 2:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 10:27 [PATCH] kselftest: add generated objects to .gitignore Muhammad Usama Anjum
2022-02-25 23:59 ` Shuah Khan
2022-02-26 2:23 ` Kees Cook [this message]
2022-02-26 6:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202202251823.138A87C@keescook \
--to=keescook@chromium.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=kernel@collabora.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox