From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8927C4332F for ; Mon, 7 Mar 2022 19:11:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244993AbiCGTMv (ORCPT ); Mon, 7 Mar 2022 14:12:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244997AbiCGTMs (ORCPT ); Mon, 7 Mar 2022 14:12:48 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 46EDA5A0AD for ; Mon, 7 Mar 2022 11:11:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646680312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xbJb2hnF7RB31QQPcCB0cHRYiPJl+mMbTgOzYpqEqG4=; b=Da4CB8bRlXGl+LZPvbSfqK/dCGDb2pL3YmLhwe86H3Tk2zXgeG5ID+1JpR2mYbYjdtaEwi QYPu1b3PQD6RyFpURCAYuTxwv3CtJG+PiDQV2sBpu6LI4H4P1UxgrYv5X2b16kknd72dDi f4SDcBpj5ec4ZSTa1W6hPleTsvhFF7U= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-383-lWBbjouPOAuoOpDipuJPag-1; Mon, 07 Mar 2022 14:11:51 -0500 X-MC-Unique: lWBbjouPOAuoOpDipuJPag-1 Received: by mail-oi1-f198.google.com with SMTP id k11-20020a54470b000000b002d538f56e6bso10213533oik.22 for ; Mon, 07 Mar 2022 11:11:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xbJb2hnF7RB31QQPcCB0cHRYiPJl+mMbTgOzYpqEqG4=; b=JcWhpwLKtyE1zffCN4FP16ne+Oh1KRAOUM03AYOvPumrDAksyzCyYd7XFin/a4nIRW wUj5y+jyBkbry+En79cBuNpgsHzxoq/tHK8oeGq+H9Y2vOTzxoreWlDohe+Xj23Q6DMQ I8SWnth3IRaBGWOQ7n/WuE56LSG8/3r59aZhCRmuoQvzdGWhMvTuVoKOEzsVa/rhbmcv L8Ii+QGg9yPXmaohT04YGeN5aBUIhSzKDmO7Z3Rk6cwh1Z8ttwNCQa6YLaTEQ8A1Vle4 A+nys6vYgFxJioCTrhA8YxDL2X7zlDbZBcD7qqSKCQSltgQindu+Kg39F89RG1oY7Zsv 6aag== X-Gm-Message-State: AOAM530GKBvp+JSyQjYNNEpGXLzj7At8fD21uZA7KD4g5Y2De9bfkN2v 819V4BGEMlFaHxfdrEkyPK3KC8N9wIDZAEvzyFJL0hAIn8EyJ7Urz+eVtb3SlfKZTo+7VUa79ms MEK8uB7iEtxAB X-Received: by 2002:a9d:6e04:0:b0:5af:6426:6d39 with SMTP id e4-20020a9d6e04000000b005af64266d39mr6603706otr.75.1646680309249; Mon, 07 Mar 2022 11:11:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrESkXA1V/9qY/xyUZhdUFyJNgxWEtqLu7JVFsEUrY4QNKlYbaQPLHPF8qRRFz3N5uWmV5CA== X-Received: by 2002:a9d:6e04:0:b0:5af:6426:6d39 with SMTP id e4-20020a9d6e04000000b005af64266d39mr6603689otr.75.1646680309017; Mon, 07 Mar 2022 11:11:49 -0800 (PST) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id o2-20020a05687072c200b000d9ae3e1fabsm5888678oak.12.2022.03.07.11.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 11:11:48 -0800 (PST) Date: Mon, 7 Mar 2022 12:11:47 -0700 From: Alex Williamson To: Leon Romanovsky Cc: Leon Romanovsky , Jason Gunthorpe , Yishai Hadas , Linux Kernel Mailing List , Linux Next Mailing List , Stephen Rothwell , linux-pci@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH vfio-next] PCI/IOV: Fix wrong kernel-doc identifier Message-ID: <20220307121147.4a12f2a7.alex.williamson@redhat.com> In-Reply-To: <8cecf7df45948a256dc56148cf9e87b2f2bb4198.1646652504.git.leonro@nvidia.com> References: <8cecf7df45948a256dc56148cf9e87b2f2bb4198.1646652504.git.leonro@nvidia.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 7 Mar 2022 13:33:25 +0200 Leon Romanovsky wrote: > From: Leon Romanovsky > > Replace "-" to be ":" in comment section to be aligned with > kernel-doc format. > > drivers/pci/iov.c:67: warning: Function parameter or member 'dev' not described in 'pci_iov_get_pf_drvdata' > drivers/pci/iov.c:67: warning: Function parameter or member 'pf_driver' not described in 'pci_iov_get_pf_drvdata' > > Fixes: a7e9f240c0da ("PCI/IOV: Add pci_iov_get_pf_drvdata() to allow VF reaching the drvdata of a PF") > Reported-by: Stephen Rothwell > Signed-off-by: Leon Romanovsky > --- > drivers/pci/iov.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c > index 28ec952e1221..952217572113 100644 > --- a/drivers/pci/iov.c > +++ b/drivers/pci/iov.c > @@ -49,8 +49,8 @@ EXPORT_SYMBOL_GPL(pci_iov_vf_id); > > /** > * pci_iov_get_pf_drvdata - Return the drvdata of a PF > - * @dev - VF pci_dev > - * @pf_driver - Device driver required to own the PF > + * @dev: VF pci_dev > + * @pf_driver: Device driver required to own the PF > * > * This must be called from a context that ensures that a VF driver is attached. > * The value returned is invalid once the VF driver completes its remove() Applied to vfio next branch for v5.18 with acks from Randy and Bjorn. Thanks, Alex