From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>,
Nico Boehr <nrb@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
thuth@redhat.com, david@redhat.com, farman@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v2 3/9] s390x: gs: move to new header file
Date: Fri, 25 Mar 2022 15:30:48 +0100 [thread overview]
Message-ID: <20220325153048.48306e40@p-imbrenda> (raw)
In-Reply-To: <a2870c6b-6b2a-0a81-435e-ec0f472697c6@linux.ibm.com>
On Fri, 25 Mar 2022 08:29:11 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:
> On 3/24/22 18:40, Heiko Carstens wrote:
> > On Wed, Mar 23, 2022 at 06:03:19PM +0100, Nico Boehr wrote:
> > ...
> >> +static inline unsigned long load_guarded(unsigned long *p)
> >> +{
> >> + unsigned long v;
> >> +
> >> + asm(".insn rxy,0xe3000000004c, %0,%1"
> >> + : "=d" (v)
> >> + : "m" (*p)
> >> + : "r14", "memory");
> >> + return v;
> >> +}
> >
> > It was like that before, but why is r14 within the clobber list?
> > That doesn't make sense.
>
> r14 is changed in the gs handler of the gs test which is executed if the
> "guarded" part of the load takes place.
I will add a comment explaining that when picking the patch
next prev parent reply other threads:[~2022-03-25 14:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 17:03 [kvm-unit-tests PATCH v2 0/9] s390x: Further extend instruction interception tests Nico Boehr
2022-03-23 17:03 ` [kvm-unit-tests PATCH v2 1/9] s390x: smp: add tests for several invalid SIGP orders Nico Boehr
2022-03-23 17:03 ` [kvm-unit-tests PATCH v2 2/9] s390x: smp: stop already stopped CPU Nico Boehr
2022-03-23 17:03 ` [kvm-unit-tests PATCH v2 3/9] s390x: gs: move to new header file Nico Boehr
2022-03-24 17:40 ` Heiko Carstens
2022-03-25 7:29 ` Janosch Frank
2022-03-25 14:30 ` Claudio Imbrenda [this message]
2022-03-25 15:07 ` Janosch Frank
2022-03-25 16:38 ` Claudio Imbrenda
2022-03-28 8:01 ` Nico Boehr
2022-03-23 17:03 ` [kvm-unit-tests PATCH v2 4/9] s390x: smp: add test for SIGP_STORE_ADTL_STATUS order Nico Boehr
2022-03-23 17:45 ` Claudio Imbrenda
2022-03-24 7:39 ` Nico Boehr
2022-03-24 13:03 ` Claudio Imbrenda
2022-03-25 13:10 ` Nico Boehr
2022-03-23 17:03 ` [kvm-unit-tests PATCH v2 5/9] s390x: smp: add tests for SET_PREFIX Nico Boehr
2022-03-23 17:03 ` [kvm-unit-tests PATCH v2 6/9] s390x: smp: add test for EMERGENCY_SIGNAL with invalid CPU address Nico Boehr
2022-03-23 17:03 ` [kvm-unit-tests PATCH v2 7/9] s390x: smp: add tests for CONDITIONAL EMERGENCY Nico Boehr
2022-03-23 17:03 ` [kvm-unit-tests PATCH v2 8/9] s390x: add TPROT tests Nico Boehr
2022-03-23 17:03 ` [kvm-unit-tests PATCH v2 9/9] s390x: stsi: check zero and ignored bits in r0 and r1 Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325153048.48306e40@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox