From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
david@redhat.com, thuth@redhat.com, nrb@linux.ibm.com,
seiden@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 6/8] s390x: css: Cleanup includes
Date: Tue, 5 Apr 2022 13:04:58 +0200 [thread overview]
Message-ID: <20220405130458.50ec1e46@p-imbrenda> (raw)
In-Reply-To: <20220405075225.15903-7-frankja@linux.ibm.com>
On Tue, 5 Apr 2022 07:52:23 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:
> Most includes were related to allocation but that's done in the io
> allocation library so having them in the test doesn't make sense.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> s390x/css.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/s390x/css.c b/s390x/css.c
> index 52d35f49..9cfcfad4 100644
> --- a/s390x/css.c
> +++ b/s390x/css.c
> @@ -9,17 +9,14 @@
> */
>
> #include <libcflat.h>
> -#include <alloc_phys.h>
> -#include <asm/page.h>
> -#include <string.h>
> #include <interrupt.h>
> -#include <asm/arch_def.h>
> -#include <alloc_page.h>
> #include <hardware.h>
>
> +#include <asm/arch_def.h>
> +#include <asm/page.h>
> +
> #include <malloc_io.h>
> #include <css.h>
> -#include <asm/barrier.h>
>
> #define DEFAULT_CU_TYPE 0x3832 /* virtio-ccw */
> static unsigned long cu_type = DEFAULT_CU_TYPE;
next prev parent reply other threads:[~2022-04-05 11:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 7:52 [kvm-unit-tests PATCH 0/8] s390x: Cleanup and maintenance 4 Janosch Frank
2022-04-05 7:52 ` [kvm-unit-tests PATCH 1/8] s390x: css: Skip if we're not run by qemu Janosch Frank
2022-04-05 8:34 ` Thomas Huth
2022-04-05 10:59 ` Claudio Imbrenda
2022-04-05 7:52 ` [kvm-unit-tests PATCH 2/8] s390x: diag308: Only test subcode 2 under QEMU Janosch Frank
2022-04-05 9:18 ` Thomas Huth
2022-04-05 9:33 ` Janosch Frank
2022-04-05 9:50 ` Thomas Huth
2022-04-05 10:24 ` Janosch Frank
2022-04-05 7:52 ` [kvm-unit-tests PATCH 3/8] s390x: pfmf: Initialize pfmf_r1 union on declaration Janosch Frank
2022-04-05 9:52 ` Thomas Huth
2022-04-05 11:03 ` Claudio Imbrenda
2022-04-05 7:52 ` [kvm-unit-tests PATCH 4/8] s390x: snippets: asm: Add license and copyright headers Janosch Frank
2022-04-05 11:04 ` Claudio Imbrenda
2022-04-05 7:52 ` [kvm-unit-tests PATCH 5/8] s390x: pv-diags: Cleanup includes Janosch Frank
2022-04-05 11:04 ` Claudio Imbrenda
2022-04-06 6:50 ` Thomas Huth
2022-04-06 15:27 ` Janosch Frank
2022-04-05 7:52 ` [kvm-unit-tests PATCH 6/8] s390x: css: " Janosch Frank
2022-04-05 11:04 ` Claudio Imbrenda [this message]
2022-04-05 7:52 ` [kvm-unit-tests PATCH 7/8] s390x: iep: " Janosch Frank
2022-04-05 11:05 ` Claudio Imbrenda
2022-04-05 7:52 ` [kvm-unit-tests PATCH 8/8] s390x: mvpg: " Janosch Frank
2022-04-05 11:05 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405130458.50ec1e46@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox