* [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU
@ 2022-04-12 9:29 Nico Boehr
2022-04-12 9:29 ` [kvm-unit-tests PATCH v1 2/3] s390x: tprot: use system include for mmu.h Nico Boehr
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Nico Boehr @ 2022-04-12 9:29 UTC (permalink / raw)
To: kvm, linux-s390; +Cc: frankja, imbrenda, thuth
When we don't run in QEMU, we didn't push a prefix, hence pop won't work. Fix
this by pushing the prefix before the QEMU check.
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
s390x/epsw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/s390x/epsw.c b/s390x/epsw.c
index 5b73f4b3db6c..d8090d95a486 100644
--- a/s390x/epsw.c
+++ b/s390x/epsw.c
@@ -97,13 +97,13 @@ static void test_epsw(void)
int main(int argc, char **argv)
{
+ report_prefix_push("epsw");
+
if (!host_is_kvm() && !host_is_tcg()) {
report_skip("Not running under QEMU");
goto done;
}
- report_prefix_push("epsw");
-
test_epsw();
done:
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [kvm-unit-tests PATCH v1 2/3] s390x: tprot: use system include for mmu.h
2022-04-12 9:29 [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU Nico Boehr
@ 2022-04-12 9:29 ` Nico Boehr
2022-04-12 9:34 ` Thomas Huth
2022-04-12 9:33 ` [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU Thomas Huth
2022-04-12 15:36 ` Janosch Frank
2 siblings, 1 reply; 7+ messages in thread
From: Nico Boehr @ 2022-04-12 9:29 UTC (permalink / raw)
To: kvm, linux-s390; +Cc: frankja, imbrenda, thuth
mmu.h should come from the system includes
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
s390x/tprot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/s390x/tprot.c b/s390x/tprot.c
index 460a0db7ffcf..760e7ecdf914 100644
--- a/s390x/tprot.c
+++ b/s390x/tprot.c
@@ -12,7 +12,7 @@
#include <bitops.h>
#include <asm/pgtable.h>
#include <asm/interrupt.h>
-#include "mmu.h"
+#include <mmu.h>
#include <vmalloc.h>
#include <sclp.h>
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [kvm-unit-tests PATCH v1 2/3] s390x: tprot: use system include for mmu.h
2022-04-12 9:29 ` [kvm-unit-tests PATCH v1 2/3] s390x: tprot: use system include for mmu.h Nico Boehr
@ 2022-04-12 9:34 ` Thomas Huth
2022-04-12 11:40 ` [kvm-unit-tests PATCH v2 2/3] s390x: tprot: use lib " Nico Boehr
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2022-04-12 9:34 UTC (permalink / raw)
To: Nico Boehr, kvm, linux-s390; +Cc: frankja, imbrenda
On 12/04/2022 11.29, Nico Boehr wrote:
> mmu.h should come from the system includes
Maybe: s/system/lib/
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
> s390x/tprot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s390x/tprot.c b/s390x/tprot.c
> index 460a0db7ffcf..760e7ecdf914 100644
> --- a/s390x/tprot.c
> +++ b/s390x/tprot.c
> @@ -12,7 +12,7 @@
> #include <bitops.h>
> #include <asm/pgtable.h>
> #include <asm/interrupt.h>
> -#include "mmu.h"
> +#include <mmu.h>
> #include <vmalloc.h>
> #include <sclp.h>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [kvm-unit-tests PATCH v2 2/3] s390x: tprot: use lib include for mmu.h
2022-04-12 9:34 ` Thomas Huth
@ 2022-04-12 11:40 ` Nico Boehr
2022-04-12 15:35 ` Janosch Frank
0 siblings, 1 reply; 7+ messages in thread
From: Nico Boehr @ 2022-04-12 11:40 UTC (permalink / raw)
To: kvm, linux-s390; +Cc: frankja, imbrenda, thuth, farman
mmu.h should come from the library includes
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
s390x/tprot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/s390x/tprot.c b/s390x/tprot.c
index 460a0db7ffcf..760e7ecdf914 100644
--- a/s390x/tprot.c
+++ b/s390x/tprot.c
@@ -12,7 +12,7 @@
#include <bitops.h>
#include <asm/pgtable.h>
#include <asm/interrupt.h>
-#include "mmu.h"
+#include <mmu.h>
#include <vmalloc.h>
#include <sclp.h>
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [kvm-unit-tests PATCH v2 2/3] s390x: tprot: use lib include for mmu.h
2022-04-12 11:40 ` [kvm-unit-tests PATCH v2 2/3] s390x: tprot: use lib " Nico Boehr
@ 2022-04-12 15:35 ` Janosch Frank
0 siblings, 0 replies; 7+ messages in thread
From: Janosch Frank @ 2022-04-12 15:35 UTC (permalink / raw)
To: Nico Boehr, kvm, linux-s390; +Cc: imbrenda, thuth, farman
On 4/12/22 13:40, Nico Boehr wrote:
> mmu.h should come from the library includes
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/tprot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s390x/tprot.c b/s390x/tprot.c
> index 460a0db7ffcf..760e7ecdf914 100644
> --- a/s390x/tprot.c
> +++ b/s390x/tprot.c
> @@ -12,7 +12,7 @@
> #include <bitops.h>
> #include <asm/pgtable.h>
> #include <asm/interrupt.h>
> -#include "mmu.h"
> +#include <mmu.h>
> #include <vmalloc.h>
> #include <sclp.h>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU
2022-04-12 9:29 [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU Nico Boehr
2022-04-12 9:29 ` [kvm-unit-tests PATCH v1 2/3] s390x: tprot: use system include for mmu.h Nico Boehr
@ 2022-04-12 9:33 ` Thomas Huth
2022-04-12 15:36 ` Janosch Frank
2 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2022-04-12 9:33 UTC (permalink / raw)
To: Nico Boehr, kvm, linux-s390; +Cc: frankja, imbrenda
On 12/04/2022 11.29, Nico Boehr wrote:
> When we don't run in QEMU, we didn't push a prefix, hence pop won't work. Fix
> this by pushing the prefix before the QEMU check.
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
> s390x/epsw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/s390x/epsw.c b/s390x/epsw.c
> index 5b73f4b3db6c..d8090d95a486 100644
> --- a/s390x/epsw.c
> +++ b/s390x/epsw.c
> @@ -97,13 +97,13 @@ static void test_epsw(void)
>
> int main(int argc, char **argv)
> {
> + report_prefix_push("epsw");
> +
> if (!host_is_kvm() && !host_is_tcg()) {
> report_skip("Not running under QEMU");
> goto done;
> }
>
> - report_prefix_push("epsw");
> -
> test_epsw();
>
> done:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU
2022-04-12 9:29 [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU Nico Boehr
2022-04-12 9:29 ` [kvm-unit-tests PATCH v1 2/3] s390x: tprot: use system include for mmu.h Nico Boehr
2022-04-12 9:33 ` [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU Thomas Huth
@ 2022-04-12 15:36 ` Janosch Frank
2 siblings, 0 replies; 7+ messages in thread
From: Janosch Frank @ 2022-04-12 15:36 UTC (permalink / raw)
To: Nico Boehr, kvm, linux-s390; +Cc: imbrenda, thuth
On 4/12/22 11:29, Nico Boehr wrote:
> When we don't run in QEMU, we didn't push a prefix, hence pop won't work. Fix
> this by pushing the prefix before the QEMU check.
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/epsw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/s390x/epsw.c b/s390x/epsw.c
> index 5b73f4b3db6c..d8090d95a486 100644
> --- a/s390x/epsw.c
> +++ b/s390x/epsw.c
> @@ -97,13 +97,13 @@ static void test_epsw(void)
>
> int main(int argc, char **argv)
> {
> + report_prefix_push("epsw");
> +
> if (!host_is_kvm() && !host_is_tcg()) {
> report_skip("Not running under QEMU");
> goto done;
> }
>
> - report_prefix_push("epsw");
> -
> test_epsw();
>
> done:
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-04-12 15:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-12 9:29 [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU Nico Boehr
2022-04-12 9:29 ` [kvm-unit-tests PATCH v1 2/3] s390x: tprot: use system include for mmu.h Nico Boehr
2022-04-12 9:34 ` Thomas Huth
2022-04-12 11:40 ` [kvm-unit-tests PATCH v2 2/3] s390x: tprot: use lib " Nico Boehr
2022-04-12 15:35 ` Janosch Frank
2022-04-12 9:33 ` [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU Thomas Huth
2022-04-12 15:36 ` Janosch Frank
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox