From: Nico Boehr <nrb@linux.ibm.com>
To: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com,
farman@linux.ibm.com
Subject: [kvm-unit-tests PATCH v1 3/3] s390x: smp: make stop stopped cpu look the same as the running case
Date: Tue, 12 Apr 2022 11:30:22 +0200 [thread overview]
Message-ID: <20220412093022.21378-1-nrb@linux.ibm.com> (raw)
Adjust the stop stopped CPU case such that it looks the same as the stop running
CPU case: use the nowait variant, handle the error code in the same way and make
the report messages look the same.
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
s390x/smp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/s390x/smp.c b/s390x/smp.c
index 5257852c35a7..de3aba71c956 100644
--- a/s390x/smp.c
+++ b/s390x/smp.c
@@ -144,8 +144,9 @@ static void test_stop(void)
report(smp_cpu_stopped(1), "cpu stopped");
report_prefix_push("stop stopped CPU");
- report(!smp_cpu_stop(1), "STOP succeeds");
- report(smp_cpu_stopped(1), "CPU is stopped");
+ rc = smp_cpu_stop_nowait(1);
+ report(!rc, "return code");
+ report(smp_cpu_stopped(1), "cpu stopped");
report_prefix_pop();
report_prefix_pop();
--
2.31.1
next reply other threads:[~2022-04-12 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:30 Nico Boehr [this message]
2022-04-12 13:25 ` [kvm-unit-tests PATCH v1 3/3] s390x: smp: make stop stopped cpu look the same as the running case Eric Farman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412093022.21378-1-nrb@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox