Re: [kvm-unit-tests PATCH v1 1/3] s390x: epsw: fix report_pop_prefix() when running under non-QEMU

Thomas Huth
2022-04-12T10:40:00Z

On 12/04/2022 11.29, Nico Boehr wrote:
> When we don't run in QEMU, we didn't push a prefix, hence pop won't work. Fix
> this by pushing the prefix before the QEMU check.
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
> s390x/epsw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/s390x/epsw.c b/s390x/epsw.c
> index 5b73f4b3db6c..d8090d95a486 100644
> --- a/s390x/epsw.c
> +++ b/s390x/epsw.c
> @@ -97,13 +97,13 @@ static void test_epsw(void)
>
> int main(int argc, char **argv)
> {
> + report_prefix_push("epsw");
> +
> if (!host_is_kvm() && !host_is_tcg()) {
> report_skip("Not running under QEMU");
> goto done;
> }
>
> - report_prefix_push("epsw");
> -
> test_epsw();
>