RE: [PATCH 9/9] vfio: Remove calls to vfio_group_add_container_user()

Tian, Kevin
2022-04-15T23:45:35Z

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Friday, April 15, 2022 8:07 PM
>
> On Fri, Apr 15, 2022 at 02:32:08AM +0000, Tian, Kevin wrote:
>
> > While it's a welcomed fix is it actually related to this series? The point
> > of this patch is that those functions are called when container_users
> > is non-zero. This is true even without this fix given container_users
> > is decremented after calling device->ops->close_device().
>
> It isn't, it is decremented before which causes it to be 0 when the
> assertions are called.
>

right, it's quite obvious when I read it the second time.