Re: [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()

Christoph Hellwig
2022-04-13T05:57:25Z

> - extern int vfio_pin_pages(struct device *dev, unsigned long *user_pfn,
> + extern int vfio_pin_pages(struct vfio_device *vdev, unsigned long *user_pfn,
> int npage, int prot, unsigned long *phys_pfn);
>
> - extern int vfio_unpin_pages(struct device *dev, unsigned long *user_pfn,
> + extern int vfio_unpin_pages(struct vfio_device *vdev, unsigned long *user_pfn,

Please drop the externs when you touch this (also for the actual
header).

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>