Re: [PATCH v3 1/8] vfio/pci: Invalidate mmaps and block the access in D3hot power state

kernel test robot
2022-04-26T01:43:12Z

Hi Abhishek,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.18-rc4]
[also build test WARNING on next-20220422]
[cannot apply to awilliam-vfio/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Abhishek-Sahu/vfio-pci-power-management-changes/20220425-173224
base: af2d861d4cd2a4da5137f795ee3509e6f944a25b
config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20220426/202204260928.TsUAxMD3-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/intel-lab-lkp/linux/commit/1d48b86a17606c483f200c1734085ab415dbfc3c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Abhishek-Sahu/vfio-pci-power-management-changes/20220425-173224
git checkout 1d48b86a17606c483f200c1734085ab415dbfc3c
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/vfio/pci/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/vfio/pci/vfio_pci_config.c:703:13: sparse: sparse: restricted pci_power_t degrades to integer
drivers/vfio/pci/vfio_pci_config.c:703:22: sparse: sparse: restricted pci_power_t degrades to integer

vim +703 drivers/vfio/pci/vfio_pci_config.c

694
695 /*
696 * It takes all the required locks to protect the access of power related
697 * variables and then invokes vfio_pci_set_power_state().
698 */
699 static void
700 vfio_lock_and_set_power_state(struct vfio_pci_core_device *vdev,
701 pci_power_t state)
702 {
> 703 if (state >= PCI_D3hot)
704 vfio_pci_zap_and_down_write_memory_lock(vdev);
705 else
706 down_write(&vdev->memory_lock);
707
708 vfio_pci_set_power_state(vdev, state);
709 up_write(&vdev->memory_lock);
710 }
711

--
0-DAY CI Kernel Test Service