From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12146C433F5 for ; Wed, 4 May 2022 20:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355432AbiEDUXC (ORCPT ); Wed, 4 May 2022 16:23:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231830AbiEDUXB (ORCPT ); Wed, 4 May 2022 16:23:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8DC7E4EDC7 for ; Wed, 4 May 2022 13:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651695563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nqBORo7onRNJucbq9ImW1EUZjcDVqkZ0T4Mz45yXwXM=; b=Vy04nugKGp5AfjpxBllgdEXtyL47o1KHre7inEyhYk0aP5gMJMD7zrLlusA0ak7m4/3KOJ kXZ1d3yTuoXmUTDChWAXPo+y/lCK+hpJLU/Br2jcjgAcnTnUJdK2nBb+mNLczGHxlqW1MK CeUyaXqbDlQpwme/TJKHAsQETtgyLuI= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-605-SYaA3QBpNViFSUgw6HwLiA-1; Wed, 04 May 2022 16:19:22 -0400 X-MC-Unique: SYaA3QBpNViFSUgw6HwLiA-1 Received: by mail-il1-f197.google.com with SMTP id s10-20020a92c5ca000000b002cc45dade1aso1271239ilt.20 for ; Wed, 04 May 2022 13:19:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=nqBORo7onRNJucbq9ImW1EUZjcDVqkZ0T4Mz45yXwXM=; b=TXv/4O6agYxsbJgFiG0RJe/Arjc/ywK/DzFarzfZHgEWyA1IHhfpnatALmHbCDBM6c hNs2pvVQtES/WPUnN4ugTxu4YchQQXMKyFdEeG3TS7a2ftGJHltqmmn7h0JPyjtQ/y1N PC0sHgRUXvo1Y4/kL8n8G3yP9mRiouX+ScWhvT/cFzKEPXx8uXf7I59i5Ags0+8xrArO QYDVGoJdVliIWBGkMSlhqkEeypziV4XC7BpcfHom0fkqUzn40xyaPg0F7Qldb3gWGFND 7+GA4P9jbUbQN0+PpN4p/aGrXzPb1OEP1AMqAeSRK3dKo3MjeuADvcEY3DGaqL/EG1w6 32Xw== X-Gm-Message-State: AOAM530fQxs18kT1ht69eb9aCXQwVcpTyYXwttITU4qqmm/HjvJLFipA isbBAVMi9bLYyGOJz30wK1iDhx3Pg4bKg5hTRt8S4MCVF/f2AzLVgq0S6L4d6m+gUh2pQFugYIL n6yGvk/A3kGMx X-Received: by 2002:a5d:9947:0:b0:654:b989:699f with SMTP id v7-20020a5d9947000000b00654b989699fmr8551402ios.170.1651695561409; Wed, 04 May 2022 13:19:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3JjSwvrEGkbnQFW5PZeCbiSWsUpDLMslxiX9NWUOort19bOk8Alhk71p1krSvTBDG/zQQcQ== X-Received: by 2002:a5d:9947:0:b0:654:b989:699f with SMTP id v7-20020a5d9947000000b00654b989699fmr8551381ios.170.1651695560807; Wed, 04 May 2022 13:19:20 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id w9-20020a056638030900b0032b3a7817d1sm4946014jap.149.2022.05.04.13.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 13:19:20 -0700 (PDT) Date: Wed, 4 May 2022 14:19:19 -0600 From: Alex Williamson To: Yishai Hadas Cc: , , , , , , , Subject: Re: [PATCH mlx5-next 0/5] Improve mlx5 live migration driver Message-ID: <20220504141919.3bb4ee76.alex.williamson@redhat.com> In-Reply-To: <4295eaec-9b11-8665-d3b4-b986a65d1d47@nvidia.com> References: <20220427093120.161402-1-yishaih@nvidia.com> <4295eaec-9b11-8665-d3b4-b986a65d1d47@nvidia.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 4 May 2022 16:29:37 +0300 Yishai Hadas wrote: > On 27/04/2022 12:31, Yishai Hadas wrote: > > This series improves mlx5 live migration driver in few aspects as of > > below. > > > > Refactor to enable running migration commands in parallel over the PF > > command interface. > > > > To achieve that we exposed from mlx5_core an API to let the VF be > > notified before that the PF command interface goes down/up. (e.g. PF > > reload upon health recovery). > > > > Once having the above functionality in place mlx5 vfio doesn't need any > > more to obtain the global PF lock upon using the command interface but > > can rely on the above mechanism to be in sync with the PF. > > > > This can enable parallel VFs migration over the PF command interface > > from kernel driver point of view. > > > > In addition, > > Moved to use the PF async command mode for the SAVE state command. > > This enables returning earlier to user space upon issuing successfully > > the command and improve latency by let things run in parallel. > > > > Alex, as this series touches mlx5_core we may need to send this in a > > pull request format to VFIO to avoid conflicts before acceptance. > > > > Yishai > > > > Yishai Hadas (5): > > vfio/mlx5: Reorganize the VF is migratable code > > net/mlx5: Expose mlx5_sriov_blocking_notifier_register / unregister > > APIs > > vfio/mlx5: Manage the VF attach/detach callback from the PF > > vfio/mlx5: Refactor to enable VFs migration in parallel > > vfio/mlx5: Run the SAVE state command in an async mode > > > > .../net/ethernet/mellanox/mlx5/core/sriov.c | 65 ++++- > > drivers/vfio/pci/mlx5/cmd.c | 229 +++++++++++++----- > > drivers/vfio/pci/mlx5/cmd.h | 50 +++- > > drivers/vfio/pci/mlx5/main.c | 133 +++++----- > > include/linux/mlx5/driver.h | 12 + > > 5 files changed, 358 insertions(+), 131 deletions(-) > > > Hi Alex, > > Did you have the chance to look at the series ? It touches mlx5 code > (vfio, net), no core changes. > > This may go apparently via your tree as a PR from mlx5-next once you'll > be fine with. As Jason noted, the net/mlx5 changes seem confined to the 2nd patch, which has no other dependencies in this series. Is there something else blocking committing that via the mlx tree and providing a branch for the remainder to go in through the vfio tree? Thanks, Alex