From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
kvm@vger.kernel.org, Longfang Liu <liulongfang@huawei.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Yishai Hadas <yishaih@nvidia.com>,
Abhishek Sahu <abhsahu@nvidia.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Subject: Re: [PATCH v4 1/2] vfio/pci: Have all VFIO PCI drivers store the vfio_pci_core_device in drvdata
Date: Fri, 6 May 2022 14:57:41 -0300 [thread overview]
Message-ID: <20220506175741.GG49344@nvidia.com> (raw)
In-Reply-To: <20220506094253.38a16c1b.alex.williamson@redhat.com>
On Fri, May 06, 2022 at 09:42:53AM -0600, Alex Williamson wrote:
> On Thu, 5 May 2022 20:21:39 -0300
> Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> > Having a consistent pointer in the drvdata will allow the next patch to
> > make use of the drvdata from some of the core code helpers.
> >
> > Use a WARN_ON inside vfio_pci_core_enable() to detect drivers that miss
> > this.
>
> Stale comment, I'll
>
> s/vfio_pci_core_enable/vfio_pci_core_register_device/
>
> on commit. Looks ok otherwise. Thanks,
Yes, thanks
Jason
next prev parent reply other threads:[~2022-05-06 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 23:21 [PATCH v4 0/2] Remove vfio_device_get_from_dev() Jason Gunthorpe
2022-05-05 23:21 ` [PATCH v4 1/2] vfio/pci: Have all VFIO PCI drivers store the vfio_pci_core_device in drvdata Jason Gunthorpe
2022-05-06 15:42 ` Alex Williamson
2022-05-06 17:57 ` Jason Gunthorpe [this message]
2022-05-09 6:35 ` Abhishek Sahu
2022-05-05 23:21 ` [PATCH v4 2/2] vfio/pci: Remove vfio_device_get_from_dev() Jason Gunthorpe
2022-05-12 18:21 ` [PATCH v4 0/2] " Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506175741.GG49344@nvidia.com \
--to=jgg@nvidia.com \
--cc=abhsahu@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=liulongfang@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox