From: Alex Williamson <alex.williamson@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
kvm@vger.kernel.org, Longfang Liu <liulongfang@huawei.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Yishai Hadas <yishaih@nvidia.com>,
Abhishek Sahu <abhsahu@nvidia.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Subject: Re: [PATCH v4 0/2] Remove vfio_device_get_from_dev()
Date: Thu, 12 May 2022 12:21:26 -0600 [thread overview]
Message-ID: <20220512122126.3c2ae5e9.alex.williamson@redhat.com> (raw)
In-Reply-To: <0-v4-c841817a0349+8f-vfio_get_from_dev_jgg@nvidia.com>
On Thu, 5 May 2022 20:21:38 -0300
Jason Gunthorpe <jgg@nvidia.com> wrote:
> Use drvdata instead of searching to find the struct vfio_device for the
> pci_driver callbacks.
>
> This applies on top of the gvt series and at least rc3 - there are no
> conflicts with the mdev vfio_group series, or the iommu series.
>
> v4:
> - Put back missing rebase hunk for vfio_group_get_from_dev()
> - Move the WARN_ON to vfio_pci_core_register_device() and move the
> dev_set_drvdata() to match
> v3: https://lore.kernel.org/r/0-v3-4adf6c1b8e7c+170-vfio_get_from_dev_jgg@nvidia.com
> - Directly access the drvdata from vfio_pci_core by making drvdata always
> point to the core struct. This will help later patches adding PM
> callbacks as well.
> v2: https://lore.kernel.org/r/0-v2-0f36bcf6ec1e+64d-vfio_get_from_dev_jgg@nvidia.com
> - Rebase on the vfio_mdev_no_group branch
> - Delete vfio_group_get_from_dev() as well due to the rebase
> v1: https://lore.kernel.org/r/0-v1-7f2292e6b2ba+44839-vfio_get_from_dev_jgg@nvidia.com
>
> Jason Gunthorpe (2):
> vfio/pci: Have all VFIO PCI drivers store the vfio_pci_core_device in
> drvdata
> vfio/pci: Remove vfio_device_get_from_dev()
>
> .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 15 +++++--
> drivers/vfio/pci/mlx5/main.c | 15 +++++--
> drivers/vfio/pci/vfio_pci.c | 6 ++-
> drivers/vfio/pci/vfio_pci_core.c | 36 +++++-----------
> drivers/vfio/vfio.c | 41 +------------------
> include/linux/vfio.h | 2 -
> include/linux/vfio_pci_core.h | 3 +-
> 7 files changed, 39 insertions(+), 79 deletions(-)
Applied to vfio next branch for v5.19. Thanks,
Alex
prev parent reply other threads:[~2022-05-12 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 23:21 [PATCH v4 0/2] Remove vfio_device_get_from_dev() Jason Gunthorpe
2022-05-05 23:21 ` [PATCH v4 1/2] vfio/pci: Have all VFIO PCI drivers store the vfio_pci_core_device in drvdata Jason Gunthorpe
2022-05-06 15:42 ` Alex Williamson
2022-05-06 17:57 ` Jason Gunthorpe
2022-05-09 6:35 ` Abhishek Sahu
2022-05-05 23:21 ` [PATCH v4 2/2] vfio/pci: Remove vfio_device_get_from_dev() Jason Gunthorpe
2022-05-12 18:21 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512122126.3c2ae5e9.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=abhsahu@nvidia.com \
--cc=cohuck@redhat.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=liulongfang@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox