From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40A9C433F5 for ; Tue, 24 May 2022 06:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234692AbiEXGFG (ORCPT ); Tue, 24 May 2022 02:05:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232516AbiEXGFF (ORCPT ); Tue, 24 May 2022 02:05:05 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB0846213D for ; Mon, 23 May 2022 23:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653372303; x=1684908303; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=diIRvvDU2jAulewT+EJl4wwfpMtzfN2iUVgeHmuFZK0=; b=irrlU/h/JEOgt9aGlFl4DgvmNuRHAliJhLt2XV/n8nss0Wnoqq9VGLje VDdze0aT3m92qU5OofJXo60DKyUowbwZvaaAyn2itz7d5VadwIMSV/Rq+ PwRgTC2DKD3LRH1D7O+3AbM7BWBnHXRsOcNkpf5En6i5/EsHCptupXAbH zcGdmWDNjTNdRZzkV9FQKG2P+YPYiWSsEzxZ2Rb/eGxoTL/jxEdWt1OvO zXRLsEtBl2LtrkirWRRtexwkL8BWetZEiCOakOmjkKw5qluVokzuvseih PQD2n2TBXuPDTTt17yUC2+xhoVUjwNtPJsB/PTG1du3IWV0aeiNYYN7K7 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="261047644" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="261047644" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 23:04:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="703336777" Received: from lkp-server01.sh.intel.com (HELO db63a1be7222) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 23 May 2022 23:04:47 -0700 Received: from kbuild by db63a1be7222 with local (Exim 4.95) (envelope-from ) id 1ntNew-0001n0-BV; Tue, 24 May 2022 06:04:46 +0000 Date: Tue, 24 May 2022 14:04:36 +0800 From: kernel test robot To: Aaron Lewis , kvm@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, pbonzini@redhat.com, jmattson@google.com, seanjc@google.com, Aaron Lewis Subject: Re: [PATCH 1/4] kvm: x86/pmu: Introduce masked events to the pmu event filter Message-ID: <202205241319.3YATdncf-lkp@intel.com> References: <20220523214110.1282480-2-aaronlewis@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220523214110.1282480-2-aaronlewis@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Aaron, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvm/master] [also build test WARNING on v5.18] [cannot apply to mst-vhost/linux-next next-20220523] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Aaron-Lewis/kvm-x86-pmu-Introduce-and-test-masked-events/20220524-054438 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git master config: i386-randconfig-a011 (https://download.01.org/0day-ci/archive/20220524/202205241319.3YATdncf-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 10c9ecce9f6096e18222a331c5e7d085bd813f75) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f189a455a73825b7025d8feff486db18ebef171f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Aaron-Lewis/kvm-x86-pmu-Introduce-and-test-masked-events/20220524-054438 git checkout f189a455a73825b7025d8feff486db18ebef171f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kvm/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> arch/x86/kvm/pmu.c:633:5: warning: no previous prototype for function 'has_invalid_event' [-Wmissing-prototypes] int has_invalid_event(struct kvm_pmu_event_filter *filter) ^ arch/x86/kvm/pmu.c:633:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int has_invalid_event(struct kvm_pmu_event_filter *filter) ^ static 1 warning generated. vim +/has_invalid_event +633 arch/x86/kvm/pmu.c 632 > 633 int has_invalid_event(struct kvm_pmu_event_filter *filter) 634 { 635 u64 event_mask; 636 int i; 637 638 event_mask = kvm_x86_ops.pmu_ops->get_event_mask(filter->flags); 639 for(i = 0; i < filter->nevents; i++) 640 if (filter->events[i] & ~event_mask) 641 return true; 642 643 return false; 644 } 645 -- 0-DAY CI Kernel Test Service https://01.org/lkp