Re: [PATCH v2 6/8] KVM: x86: Bug the VM if the emulator accesses a non-existent GPR

Sean Christopherson
2022-06-02T16:01:34Z

On Wed, Jun 01, 2022, Vitaly Kuznetsov wrote:
> > static const struct x86_emulate_ops emulate_ops = {
> > + .vm_bugged = emulator_vm_bugged,
> > .read_gpr = emulator_read_gpr,
> > .write_gpr = emulator_write_gpr,
> > .read_std = emulator_read_std,
>
> Is it actually "vm_bugged" or "kvm_bugged"? :-)

vm_bugged. KVM_BUG_ON() because it's a KVM bug on the condition, but the invididual
VM is what's bugged/dead, i.e. other VMs and thus KVM itself get to live on. :-)