Re: [PATCH] KVM: s390: selftests: Fix memop extension capability check

Paolo Bonzini
2022-06-14T17:09:46Z

On 6/14/22 18:26, Janis Schoetterl-Glausch wrote:
> Fix the inverted logic of the memop extension capability check.
>
> Fixes: 97da92c0ff92 ("KVM: s390: selftests: Use TAP interface in the memop test")
> Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> ---
>
>
> Here you go.
> Hope it doesn't get lost as a reply, but I can always resend
> and it's not super critical after all.
>
>
> tools/testing/selftests/kvm/s390x/memop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/s390x/memop.c b/tools/testing/selftests/kvm/s390x/memop.c
> index e704c6fa5758..e1056f20dfa1 100644
> --- a/tools/testing/selftests/kvm/s390x/memop.c
> +++ b/tools/testing/selftests/kvm/s390x/memop.c
> @@ -769,7 +769,7 @@ int main(int argc, char *argv[])
> ksft_set_plan(ARRAY_SIZE(testlist));
>
> for (idx = 0; idx < ARRAY_SIZE(testlist); idx++) {
> - if (testlist[idx].extension >= extension_cap) {
> + if (extension_cap >= testlist[idx].extension) {
> testlist[idx].test();
> ksft_test_result_pass("%s\n", testlist[idx].name);
> } else {

Done, thanks!

Paolo