From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: KVM <kvm@vger.kernel.org>, Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
linux-s390 <linux-s390@vger.kernel.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>
Subject: [GIT PULL 15/15] KVM: s390: selftests: Use TAP interface in the reset test
Date: Wed, 1 Jun 2022 17:36:46 +0200 [thread overview]
Message-ID: <20220601153646.6791-16-borntraeger@linux.ibm.com> (raw)
In-Reply-To: <20220601153646.6791-1-borntraeger@linux.ibm.com>
From: Thomas Huth <thuth@redhat.com>
Let's standardize the s390x KVM selftest output to the TAP output
generated via the kselftests.h interface.
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Link: https://lore.kernel.org/r/20220531101554.36844-5-thuth@redhat.com
Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
---
tools/testing/selftests/kvm/s390x/resets.c | 38 +++++++++++++++++-----
1 file changed, 30 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/kvm/s390x/resets.c b/tools/testing/selftests/kvm/s390x/resets.c
index b143db6d8693..889449a22e7a 100644
--- a/tools/testing/selftests/kvm/s390x/resets.c
+++ b/tools/testing/selftests/kvm/s390x/resets.c
@@ -12,6 +12,7 @@
#include "test_util.h"
#include "kvm_util.h"
+#include "kselftest.h"
#define VCPU_ID 3
#define LOCAL_IRQS 32
@@ -202,7 +203,7 @@ static void inject_irq(int cpu_id)
static void test_normal(void)
{
- pr_info("Testing normal reset\n");
+ ksft_print_msg("Testing normal reset\n");
/* Create VM */
vm = vm_create_default(VCPU_ID, 0, guest_code_initial);
run = vcpu_state(vm, VCPU_ID);
@@ -225,7 +226,7 @@ static void test_normal(void)
static void test_initial(void)
{
- pr_info("Testing initial reset\n");
+ ksft_print_msg("Testing initial reset\n");
vm = vm_create_default(VCPU_ID, 0, guest_code_initial);
run = vcpu_state(vm, VCPU_ID);
sync_regs = &run->s.regs;
@@ -247,7 +248,7 @@ static void test_initial(void)
static void test_clear(void)
{
- pr_info("Testing clear reset\n");
+ ksft_print_msg("Testing clear reset\n");
vm = vm_create_default(VCPU_ID, 0, guest_code_initial);
run = vcpu_state(vm, VCPU_ID);
sync_regs = &run->s.regs;
@@ -266,14 +267,35 @@ static void test_clear(void)
kvm_vm_free(vm);
}
+struct testdef {
+ const char *name;
+ void (*test)(void);
+ bool needs_cap;
+} testlist[] = {
+ { "initial", test_initial, false },
+ { "normal", test_normal, true },
+ { "clear", test_clear, true },
+};
+
int main(int argc, char *argv[])
{
+ bool has_s390_vcpu_resets = kvm_check_cap(KVM_CAP_S390_VCPU_RESETS);
+ int idx;
+
setbuf(stdout, NULL); /* Tell stdout not to buffer its content */
- test_initial();
- if (kvm_check_cap(KVM_CAP_S390_VCPU_RESETS)) {
- test_normal();
- test_clear();
+ ksft_print_header();
+ ksft_set_plan(ARRAY_SIZE(testlist));
+
+ for (idx = 0; idx < ARRAY_SIZE(testlist); idx++) {
+ if (!testlist[idx].needs_cap || has_s390_vcpu_resets) {
+ testlist[idx].test();
+ ksft_test_result_pass("%s\n", testlist[idx].name);
+ } else {
+ ksft_test_result_skip("%s - no VCPU_RESETS capability\n",
+ testlist[idx].name);
+ }
}
- return 0;
+
+ ksft_finished(); /* Print results and exit() accordingly */
}
--
2.35.1
next prev parent reply other threads:[~2022-06-01 15:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 15:36 [GIT PULL 00/15] KVM: s390: pv dump and selftest changes Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 01/15] s390/uv: Add SE hdr query information Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 02/15] s390/uv: Add dump fields to query Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 03/15] KVM: s390: pv: Add query interface Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 04/15] KVM: s390: pv: Add dump support definitions Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 05/15] KVM: s390: pv: Add query dump information Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 06/15] KVM: s390: Add configuration dump functionality Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 07/15] KVM: s390: Add CPU " Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 08/15] KVM: s390: Add KVM_CAP_S390_PROTECTED_DUMP Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 09/15] Documentation: virt: Protected virtual machine dumps Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 10/15] Documentation/virt/kvm/api.rst: Add protvirt dump/info api descriptions Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 11/15] Documentation/virt/kvm/api.rst: Explain rc/rrc delivery Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 12/15] KVM: s390: selftests: Use TAP interface in the memop test Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 13/15] KVM: s390: selftests: Use TAP interface in the sync_regs test Christian Borntraeger
2022-06-01 15:36 ` [GIT PULL 14/15] KVM: s390: selftests: Use TAP interface in the tprot test Christian Borntraeger
2022-06-01 15:36 ` Christian Borntraeger [this message]
2022-06-07 16:27 ` [GIT PULL 00/15] KVM: s390: pv dump and selftest changes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601153646.6791-16-borntraeger@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox