From: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [kvm-unit-tests PATCH v3 2/2] s390x: Fix gcc 12 warning about array bounds
Date: Wed, 8 Jun 2022 14:29:53 +0200 [thread overview]
Message-ID: <20220608122953.1051952-3-scgl@linux.ibm.com> (raw)
In-Reply-To: <20220608122953.1051952-1-scgl@linux.ibm.com>
gcc 12 warns about pointer constant <4k dereference.
Silence the warning by using the extern lowcore symbol to derive the
pointers. This way gcc cannot conclude that the pointer is <4k.
Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
---
lib/s390x/asm/mem.h | 4 ++++
s390x/emulator.c | 5 +++--
s390x/skey.c | 2 +-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/s390x/asm/mem.h b/lib/s390x/asm/mem.h
index 845c00cc..64ef59b5 100644
--- a/lib/s390x/asm/mem.h
+++ b/lib/s390x/asm/mem.h
@@ -7,6 +7,10 @@
*/
#ifndef _ASMS390X_MEM_H_
#define _ASMS390X_MEM_H_
+#include <asm/arch_def.h>
+
+/* create pointer while avoiding compiler warnings */
+#define OPAQUE_PTR(x) ((void *)(((uint64_t)&lowcore) + (x)))
#define SKEY_ACC 0xf0
#define SKEY_FP 0x08
diff --git a/s390x/emulator.c b/s390x/emulator.c
index c9182ea4..2c42f96f 100644
--- a/s390x/emulator.c
+++ b/s390x/emulator.c
@@ -12,6 +12,7 @@
#include <asm/cpacf.h>
#include <asm/interrupt.h>
#include <asm/float.h>
+#include <asm/mem.h>
#include <linux/compiler.h>
static inline void __test_spm_ipm(uint8_t cc, uint8_t key)
@@ -138,7 +139,7 @@ static __always_inline void __test_cpacf_invalid_parm(unsigned int opcode)
{
report_prefix_push("invalid parm address");
expect_pgm_int();
- __cpacf_query(opcode, (void *) -1);
+ __cpacf_query(opcode, OPAQUE_PTR(-1));
check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
report_prefix_pop();
}
@@ -148,7 +149,7 @@ static __always_inline void __test_cpacf_protected_parm(unsigned int opcode)
report_prefix_push("protected parm address");
expect_pgm_int();
low_prot_enable();
- __cpacf_query(opcode, (void *) 8);
+ __cpacf_query(opcode, OPAQUE_PTR(8));
low_prot_disable();
check_pgm_int_code(PGM_INT_CODE_PROTECTION);
report_prefix_pop();
diff --git a/s390x/skey.c b/s390x/skey.c
index 32bf1070..445476a0 100644
--- a/s390x/skey.c
+++ b/s390x/skey.c
@@ -349,7 +349,7 @@ static void test_set_prefix(void)
set_storage_key(pagebuf, 0x28, 0);
expect_pgm_int();
install_page(root, virt_to_pte_phys(root, pagebuf), 0);
- set_prefix_key_1((uint32_t *)2048);
+ set_prefix_key_1(OPAQUE_PTR(2048));
install_page(root, 0, 0);
check_pgm_int_code(PGM_INT_CODE_PROTECTION);
report(get_prefix() == old_prefix, "did not set prefix");
--
2.33.1
next prev parent reply other threads:[~2022-06-08 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 12:29 [kvm-unit-tests PATCH v3 0/2] s390x: Avoid gcc 12 warnings Janis Schoetterl-Glausch
2022-06-08 12:29 ` [kvm-unit-tests PATCH v3 1/2] s390x: Introduce symbol for lowcore and use it Janis Schoetterl-Glausch
2022-06-08 12:29 ` Janis Schoetterl-Glausch [this message]
2022-06-08 13:34 ` [kvm-unit-tests PATCH v3 0/2] s390x: Avoid gcc 12 warnings Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608122953.1051952-3-scgl@linux.ibm.com \
--to=scgl@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox