From: Alex Williamson <alex.williamson@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: kvm@vger.kernel.org, airlied@linux.ie,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laszlo Ersek <lersek@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 2/2] vfio/pci: Remove console drivers
Date: Thu, 9 Jun 2022 15:41:02 -0600 [thread overview]
Message-ID: <20220609154102.5cb1d3ca.alex.williamson@redhat.com> (raw)
In-Reply-To: <01c74525-38b7-1e00-51ba-7cd793439f03@suse.de>
On Thu, 9 Jun 2022 11:13:22 +0200
Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Please have a look at the attached patch. It moves the aperture helpers
> to a location common to the various possible users (DRM, fbdev, vfio).
> The DRM interfaces remain untouched for now. The patch should provide
> what you need in vfio and also serve our future use cases for graphics
> drivers. If possible, please create your patch on top of it.
Looks good to me, this of course makes the vfio change quite trivial.
One change I'd request:
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index 40c50fa2dd70..7f3c44e1538b 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kconfig
@@ -10,6 +10,7 @@ config VGA_CONSOLE
depends on !4xx && !PPC_8xx && !SPARC && !M68K && !PARISC && !SUPERH && \
(!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \
!ARM64 && !ARC && !MICROBLAZE && !OPENRISC && !S390 && !UML
+ select APERTURE_HELPERS if (DRM || FB || VFIO_PCI)
default y
help
Saying Y here will allow you to use Linux in text mode through a
This should be VFIO_PCI_CORE. Thanks,
Alex
next prev parent reply other threads:[~2022-06-09 21:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 17:53 [PATCH 0/2] Improve vfio-pci primary GPU assignment behavior Alex Williamson
2022-06-06 17:53 ` [PATCH 1/2] drm/aperture: Split conflicting platform driver removal Alex Williamson
2022-06-06 17:53 ` [PATCH 2/2] vfio/pci: Remove console drivers Alex Williamson
2022-06-08 11:11 ` Thomas Zimmermann
2022-06-08 14:04 ` Alex Williamson
2022-06-09 9:13 ` Thomas Zimmermann
2022-06-09 21:41 ` Alex Williamson [this message]
2022-06-09 21:44 ` Alex Williamson
2022-06-10 7:03 ` Thomas Zimmermann
2022-06-10 14:30 ` Alex Williamson
2022-06-08 15:37 ` Gerd Hoffmann
2022-06-07 17:40 ` [PATCH 0/2] Improve vfio-pci primary GPU assignment behavior Javier Martinez Canillas
2022-06-07 21:01 ` Alex Williamson
2022-06-08 7:43 ` Gerd Hoffmann
2022-06-08 8:51 ` Javier Martinez Canillas
2022-06-08 9:11 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2022-12-04 0:12 [PATCH 2/2] vfio/pci: Remove console drivers mb
2022-12-05 0:51 ` Alex Williamson
2022-12-05 9:00 ` Thomas Zimmermann
[not found] ` <CAEdEoBYZa9cg0nq=P7EDsDS9m2EKYrd8M8ucqi8U0Csj0mtjDg@mail.gmail.com>
2022-12-05 10:11 ` Thomas Zimmermann
2022-12-05 21:50 ` mb
2023-01-02 10:33 ` Shawn Michaels
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609154102.5cb1d3ca.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox