From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 025D7C433EF for ; Mon, 13 Jun 2022 06:47:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236950AbiFMGrE (ORCPT ); Mon, 13 Jun 2022 02:47:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230320AbiFMGrB (ORCPT ); Mon, 13 Jun 2022 02:47:01 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8517B101FF; Sun, 12 Jun 2022 23:46:59 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id D33CB68AA6; Mon, 13 Jun 2022 08:46:55 +0200 (CEST) Date: Mon, 13 Jun 2022 08:46:55 +0200 From: Christoph Hellwig To: "Tian, Kevin" Cc: Eric Farman , Kirti Wankhede , Matthew Rosato , Jason Gunthorpe , Alex Williamson , "Liu, Yi L" , Halil Pasic , "kvm@vger.kernel.org" , "linux-s390@vger.kernel.org" , Jonathan Corbet , Tony Krowiak , Jason Herne , Christoph Hellwig , Neo Jia , Dheeraj Nigam , Tarun Gupta Subject: Re: [PATCH v1 14/18] vfio/mdev: Add mdev available instance checking to the core Message-ID: <20220613064655.GA493@lst.de> References: <20220602171948.2790690-1-farman@linux.ibm.com> <20220602171948.2790690-15-farman@linux.ibm.com> <63a87e1e-7d99-b091-4c6b-fa25dd7c5211@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jun 10, 2022 at 07:43:46AM +0000, Tian, Kevin wrote: > btw with those latest changes [1] we don't need .get_available() then, > as mdev type is now added by mdev driver one-by-one then the > available instance can be provided directly in that path. Yes, we can probably add a helper to add the vailable attibrute, which takes the number of instances. Is it ok if I just add a version of this patch and the device_api one to my series, and we rebase this series on top of it? I'll try to get out a new version ASAP.