From: Chao Gao <chao.gao@intel.com>
To: Shenming Lu <lushenming@bytedance.com>
Cc: Zeng Guang <guang.zeng@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
Tony Luck <tony.luck@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Kim Phillips <kim.phillips@amd.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jethro Beekman <jethro@fortanix.com>,
Kai Huang <kai.huang@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Robert Hu <robert.hu@intel.com>,
zhouyibo@bytedance.com
Subject: Re: [External] [PATCH v9 9/9] KVM: VMX: enable IPI virtualization
Date: Mon, 20 Jun 2022 19:00:02 +0800 [thread overview]
Message-ID: <20220620105957.GA9496@gao-cwp> (raw)
In-Reply-To: <cdead652-cbd6-90e4-dab8-9cb18f71a624@bytedance.com>
On Mon, Jun 20, 2022 at 06:02:32PM +0800, Shenming Lu wrote:
>> + if (enable_ipiv)
>> + tertiary_exec_controls_clearbit(vmx, TERTIARY_EXEC_IPI_VIRT);
>> + }
>> vmx_update_msr_bitmap_x2apic(vcpu);
>> }
>
>Hi, just a small question here:
>
>It seems that we clear the TERTIARY_EXEC_IPI_VIRT bit before enabling
>interception for APIC_ICR when deactivating APICv on some reason.
>Is there any problem with this sequence?
Both are done before the next vCPU entry. As long as no guest code can
run between them (APICv setting takes effect in guest), this sequence
shouldn't have any problem.
next prev parent reply other threads:[~2022-06-20 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 15:45 [PATCH v9 9/9] KVM: VMX: enable IPI virtualization Zeng Guang
2022-05-02 16:16 ` Paolo Bonzini
2022-05-03 2:44 ` Zeng Guang
2022-06-20 10:02 ` [External] " Shenming Lu
2022-06-20 11:00 ` Chao Gao [this message]
2022-06-21 2:23 ` Shenming Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620105957.GA9496@gao-cwp \
--to=chao.gao@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=guang.zeng@intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=jethro@fortanix.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lushenming@bytedance.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=robert.hu@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=zhouyibo@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox