From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Yishai Hadas <yishaih@nvidia.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"maorg@nvidia.com" <maorg@nvidia.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
liulongfang <liulongfang@huawei.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Subject: Re: [PATCH vfio 2/2] vfio: Split migration ops from main device ops
Date: Fri, 24 Jun 2022 11:53:58 -0300 [thread overview]
Message-ID: <20220624145358.GT4147@nvidia.com> (raw)
In-Reply-To: <20220624084125.6d819a3c.alex.williamson@redhat.com>
On Fri, Jun 24, 2022 at 08:41:25AM -0600, Alex Williamson wrote:
> > RDMA uses a function ib_set_device_ops() but that is only because
> > there is alot of code in that function to do the copying of ops
> > pointers. Splitting avoids the copying so we don't really need a
> > function.
>
> So maybe we just need a comment in the definition of the
> vfio_migration_ops that vfio_device.mig_ops is a static property of the
> vfio_device which must be set prior to registering the vfio_device.
Sure
Jason
prev parent reply other threads:[~2022-06-24 14:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 8:56 [PATCH vfio 0/2] Migration few enhancements Yishai Hadas
2022-06-06 8:56 ` [PATCH vfio 1/2] vfio/mlx5: Protect mlx5vf_disable_fds() upon close device Yishai Hadas
2022-06-10 3:25 ` Tian, Kevin
2022-06-06 8:56 ` [PATCH vfio 2/2] vfio: Split migration ops from main device ops Yishai Hadas
2022-06-10 3:32 ` Tian, Kevin
2022-06-13 7:13 ` Yishai Hadas
2022-06-16 14:18 ` Yishai Hadas
2022-06-16 23:01 ` Alex Williamson
2022-06-17 3:58 ` Tian, Kevin
2022-06-17 4:04 ` Tian, Kevin
2022-06-17 8:50 ` Shameerali Kolothum Thodi
2022-06-17 14:47 ` Alex Williamson
2022-06-19 9:25 ` Yishai Hadas
2022-06-20 3:49 ` Jason Gunthorpe
2022-06-21 16:41 ` Alex Williamson
2022-06-24 14:12 ` Jason Gunthorpe
2022-06-24 14:41 ` Alex Williamson
2022-06-24 14:53 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624145358.GT4147@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=maorg@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).