From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Kirti Wankhede <kwankhede@nvidia.com>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
intel-gvt-dev@lists.freedesktop.org,
Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH 04/13] vfio/mdev: simplify mdev_type handling
Date: Wed, 29 Jun 2022 09:17:09 -0300 [thread overview]
Message-ID: <20220629121709.GI693670@nvidia.com> (raw)
In-Reply-To: <20220628155915.060ba2d9.alex.williamson@redhat.com>
On Tue, Jun 28, 2022 at 03:59:15PM -0600, Alex Williamson wrote:
> > + strcpy(matrix_dev->mdev_type.sysfs_name, VFIO_AP_MDEV_TYPE_HWVIRT);
>
> And then this might as well be an snprintf() as well too.
Kees has setup FORTIFY so the above will actually throw a compile
warning in build bots if the array size is too small. Changing it to
snprintf would loose this and cause undetected string truncation.
Jason
next prev parent reply other threads:[~2022-06-29 12:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 5:14 simplify the mdev interface v3 Christoph Hellwig
2022-06-28 5:14 ` [PATCH 01/13] drm/i915/gvt: fix a memory leak in intel_gvt_init_vgpu_types Christoph Hellwig
2022-06-28 8:17 ` Zhenyu Wang
2022-06-28 9:41 ` Tian, Kevin
2022-06-28 5:14 ` [PATCH 02/13] vfio/mdev: make mdev.h standalone includable Christoph Hellwig
2022-06-28 5:14 ` [PATCH 03/13] vfio/mdev: embedd struct mdev_parent in the parent data structure Christoph Hellwig
2022-06-28 9:44 ` Tian, Kevin
2022-06-28 5:14 ` [PATCH 04/13] vfio/mdev: simplify mdev_type handling Christoph Hellwig
2022-06-28 21:59 ` Alex Williamson
2022-06-29 12:17 ` Jason Gunthorpe [this message]
2022-07-04 6:18 ` Christoph Hellwig
2022-06-28 5:14 ` [PATCH 05/13] vfio/mdev: remove mdev_from_dev Christoph Hellwig
2022-06-28 5:14 ` [PATCH 06/13] vfio/mdev: unexport mdev_bus_type Christoph Hellwig
2022-06-28 5:14 ` [PATCH 07/13] vfio/mdev: remove mdev_parent_dev Christoph Hellwig
2022-06-28 5:14 ` [PATCH 08/13] vfio/mdev: remove mtype_get_parent_dev Christoph Hellwig
2022-06-30 16:24 ` Jason J. Herne
2022-06-28 5:14 ` [PATCH 09/13] vfio/mdev: consolidate all the device_api sysfs into the core code Christoph Hellwig
2022-06-28 5:14 ` [PATCH 10/13] vfio/mdev: consolidate all the name " Christoph Hellwig
2022-06-28 5:14 ` [PATCH 11/13] vfio/mdev: consolidate all the available_instance " Christoph Hellwig
2022-06-28 5:14 ` [PATCH 12/13] vfio/mdev: consolidate all the description " Christoph Hellwig
2022-06-28 9:49 ` Tian, Kevin
2022-06-28 5:14 ` [PATCH 13/13] vfio/mdev: add mdev available instance checking to the core Christoph Hellwig
2022-06-28 9:56 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629121709.GI693670@nvidia.com \
--to=jgg@nvidia.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=farman@linux.ibm.com \
--cc=hch@lst.de \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jjherne@linux.ibm.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox