Re: [PATCH v3 00/11] s390/vfio-ccw rework

Yi Liu
2022-07-04T02:16:38Z

On 2022/7/1 20:40, Eric Farman wrote:
> On Thu, 2022-06-30 at 20:44 -0300, Jason Gunthorpe wrote:
>> On Thu, Jun 30, 2022 at 10:36:36PM +0200, Eric Farman wrote:
>>> Here's an updated pass through the first chunk of vfio-ccw rework.
>>>
>>> As with v2, this is all internal to vfio-ccw, with the exception of
>>> the removal of mdev_uuid from include/linux/mdev.h in patch 1.
>>>
>>> There is one conflict with the vfio-next branch [2], on patch 6.
>>
>> What tree do you plan to take it through?
>
> Don't know. I know Matt's PCI series has a conflict with this same
> patch also, but I haven't seen resolution to that. @Christian,
> thoughts?
>
>>
>>> The remainder of the work that Jason Gunthorpe originally started
>>> [1]
>>> in this space remains for a future day.
>>
>> Lets see.. These were already applied:
>>
>> vfio/ccw: Remove unneeded GFP_DMA
>> vfio/ccw: Use functions for alloc/free of the vfio_ccw_private
>> vfio/ccw: Pass vfio_ccw_private not mdev_device to various
>> functions
>> vfio/ccw: Convert to use vfio_register_emulated_iommu_dev()
>>
>> This series replaces this one:
>> vfio/ccw: Make the FSM complete and synchronize it to the mdev
>>
>> Christoph recently re-posted this:
>> https://lore.kernel.org/kvm/20220628051435.695540-10-hch@lst.de/
>> vfio/mdev: Consolidate all the device_api sysfs into the core code
>
> Correct. Same for "vfio/mdev: Add mdev available instance checking to
> the core" which you originally had proposed.
>
>>
>> So this is still left ?
>> vfio/ccw: Remove private->mdev
>
> This is by this series (patch 1-4).
>
>> vfio: Export vfio_device_try_get()
>> vfio/ccw: Move the lifecycle of the struct vfio_ccw_private to the
>> mdev
>>
>> IIRC Kevin's team needs those for their device FD patches?
>
> That's my understanding too.

yes. You two have great memory. My vfio cdev patches relies on these two
patches. So far, my branch doesn't cover ccw. Do you have plan to
incorporate them? I would like to apply your ccw series to below branch.

https://github.com/luxis1999/iommufd/commit/e6e52d0d2bba6510c0a9fec8184d5f169a50fda2

>>
>> Thanks,
>> Jason
>

--
Regards,
Yi Liu