From: Jason Gunthorpe <jgg@nvidia.com>
To: "chenxiang (M)" <chenxiang66@hisilicon.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Will Deacon <will@kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Christoph Hellwig <hch@lst.de>,
"Tian, Kevin" <kevin.tian@intel.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v3 4/4] vfio: Require that devices support DMA cache coherence
Date: Mon, 4 Jul 2022 10:27:39 -0300 [thread overview]
Message-ID: <20220704132739.GP693670@nvidia.com> (raw)
In-Reply-To: <40454b70-11e1-f9a1-6c26-27e7340f2109@hisilicon.com>
On Mon, Jul 04, 2022 at 09:21:26PM +0800, chenxiang (M) wrote:
> Hi,
>
> We encounter a issue with the patch: our platform is ARM64, and we run DPDK
> with smmu disable on VM (without iommu=smmuv3 etc),
>
> so we use noiommu mode with enable_unsafe_noiommu_mode=1 to passthrough the
> device to VM with following steps (those steps are on VM) :
>
> insmod vfio.ko enable_unsafe_noiommu_mode=1
> insmod vfio_virqfd.ko
> insmod vfio-pci-core.ko
> insmdo vfio-pci.ko
> insmod vfio_iommu_type1.ko
>
> echo vfio-pci > /sys/bus/pci/devices/0000:00:02.0/driver_override
> echo 0000:00:02.0 > /sys/bus/pci/drivers_probe ------------------ failed
>
> I find that vfio-pci device is not probed because of the additional check.
> It works well without this patch.
>
> Do we need to skip the check if enable_unsafe_noiommu_mode=1?
Yes, that is definately an unintended mistake.
Thanks,
Jason
next prev parent reply other threads:[~2022-07-04 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 15:16 [PATCH v3 0/4] Make the iommu driver no-snoop block feature consistent Jason Gunthorpe
2022-04-11 15:16 ` [PATCH v3 1/4] iommu: Introduce the domain op enforce_cache_coherency() Jason Gunthorpe
2022-04-11 15:16 ` [PATCH v3 2/4] vfio: Move the Intel no-snoop control off of IOMMU_CACHE Jason Gunthorpe
2022-04-11 15:16 ` [PATCH v3 3/4] iommu: Redefine IOMMU_CAP_CACHE_COHERENCY as the cap flag for IOMMU_CACHE Jason Gunthorpe
2022-04-11 15:16 ` [PATCH v3 4/4] vfio: Require that devices support DMA cache coherence Jason Gunthorpe
2022-07-04 13:21 ` chenxiang (M)
2022-07-04 13:27 ` Jason Gunthorpe [this message]
2022-04-28 8:56 ` [PATCH v3 0/4] Make the iommu driver no-snoop block feature consistent Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704132739.GP693670@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox