public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org,
	Robin Murphy <robin.murphy@arm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Joerg Roedel <jroedel@suse.de>, Joel Stanley <joel@jms.id.au>,
	Alex Williamson <alex.williamson@redhat.com>,
	Oliver O'Halloran <oohall@gmail.com>,
	kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
	Daniel Henrique Barboza <danielhb413@gmail.com>,
	Fabiano Rosas <farosas@linux.ibm.com>,
	Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH kernel] powerpc/iommu: Add iommu_ops to report capabilities and allow blocking domains
Date: Fri, 8 Jul 2022 08:55:22 -0300	[thread overview]
Message-ID: <20220708115522.GD1705032@nvidia.com> (raw)
In-Reply-To: <bbe29694-66a3-275b-5a79-71237ad7388f@ozlabs.ru>

On Fri, Jul 08, 2022 at 04:34:55PM +1000, Alexey Kardashevskiy wrote:

> For now I'll add a comment in spapr_tce_iommu_attach_dev() that it is fine
> to do nothing as tce_iommu_take_ownership() and
> tce_iommu_take_ownership_ddw() take care of not having active DMA mappings.

That will still cause a security problem because
tce_iommu_take_ownership()/etc are called too late. This is the moment
in the flow when the ownershift must change away from the DMA API that
power implements and to VFIO, not later.

Jason

  parent reply	other threads:[~2022-07-08 11:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 13:55 [PATCH kernel] powerpc/iommu: Add iommu_ops to report capabilities and allow blocking domains Alexey Kardashevskiy
2022-07-07 15:10 ` Jason Gunthorpe
2022-07-08  5:00   ` Alexey Kardashevskiy
2022-07-08  6:34     ` Alexey Kardashevskiy
2022-07-08  7:32       ` Tian, Kevin
2022-07-08  9:45         ` Alexey Kardashevskiy
2022-07-08 10:18           ` Tian, Kevin
2022-07-29  2:21         ` Alexey Kardashevskiy
2022-07-29  2:53           ` Oliver O'Halloran
2022-07-29  3:10             ` Tian, Kevin
2022-07-29  3:50               ` Alexey Kardashevskiy
2022-07-29  4:24                 ` Tian, Kevin
2022-07-29 12:09                   ` Jason Gunthorpe
2022-07-08 11:55       ` Jason Gunthorpe [this message]
2022-07-08 13:10         ` Alexey Kardashevskiy
2022-07-08 13:19           ` Jason Gunthorpe
2022-07-08 13:32             ` Alexey Kardashevskiy
2022-07-08 13:59               ` Jason Gunthorpe
2022-07-09  2:58         ` Alexey Kardashevskiy
2022-07-10  6:29           ` Jason Gunthorpe
2022-07-10 12:32             ` Alexey Kardashevskiy
2022-07-11 13:24               ` Alexey Kardashevskiy
2022-07-11 18:46                 ` Jason Gunthorpe
2022-07-12  2:27                   ` Alexey Kardashevskiy
2022-07-12  5:44                     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220708115522.GD1705032@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=danielhb413@gmail.com \
    --cc=farosas@linux.ibm.com \
    --cc=joel@jms.id.au \
    --cc=jroedel@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=muriloo@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=oohall@gmail.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox