Re: [PATCH 2/2] vfio/ccw: Remove FSM Close from remove handlers

Matthew Rosato
2022-07-26T16:19:23Z

On 7/26/22 11:01 AM, Eric Farman wrote:
> Now that neither vfio_ccw_sch_probe() nor vfio_ccw_mdev_probe()
> affect the FSM state, it doesn't make sense for their _remove()
> counterparts try to revert things in this way. Since the FSM open
> and close are handled alongside MDEV open/close, these are
> unnecessary.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>

> ---
> drivers/s390/cio/vfio_ccw_drv.c | 1 -
> drivers/s390/cio/vfio_ccw_ops.c | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 4804101ccb0f..86d9e428357b 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -241,7 +241,6 @@ static void vfio_ccw_sch_remove(struct subchannel *sch)
> {
> struct vfio_ccw_private *private = dev_get_drvdata(&sch->dev);
>
> - vfio_ccw_fsm_event(private, VFIO_CCW_EVENT_CLOSE);
> mdev_unregister_device(&sch->dev);
>
> dev_set_drvdata(&sch->dev, NULL);
> diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_ccw_ops.c
> index 3f67fa103c7f..4a806a2273b5 100644
> --- a/drivers/s390/cio/vfio_ccw_ops.c
> +++ b/drivers/s390/cio/vfio_ccw_ops.c
> @@ -130,8 +130,6 @@ static void vfio_ccw_mdev_remove(struct mdev_device *mdev)
>
> vfio_unregister_group_dev(&private->vdev);
>
> - vfio_ccw_fsm_event(private, VFIO_CCW_EVENT_CLOSE);
> -
> vfio_uninit_group_dev(&private->vdev);
> atomic_inc(&private->avail);
> }