Re: [kvm-unit-tests PATCH 3/6] s390x: Add a linker script to assembly snippets

Nico Boehr
2022-08-02T07:17:38Z

Quoting Janosch Frank (2022-07-29 10:26:30)
[...]
> diff --git a/s390x/pv-diags.c b/s390x/pv-diags.c
> index 9ced68c7..5165937a 100644
> --- a/s390x/pv-diags.c
> +++ b/s390x/pv-diags.c
> @@ -28,7 +28,7 @@ static void test_diag_500(void)
>
> snippet_pv_init(&vm, SNIPPET_NAME_START(asm, snippet_pv_diag_500),
> SNIPPET_HDR_START(asm, snippet_pv_diag_500),
> - size_gbin, size_hdr, SNIPPET_OFF_ASM);
> + size_gbin, size_hdr, SNIPPET_UNPACK_OFF);

Does it even make sense to pass SNIPPET_UNPACK_OFF? Since this is now the same for C and ASM we could completely get rid of this argument, couldn't we?