public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Maxim Levitsky" <mlevitsk@redhat.com>,
	kvm@vger.kernel.org,
	"Emanuele Giuseppe Esposito" <eesposit@redhat.com>
Subject: [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls
Date: Tue, 16 Aug 2022 06:12:49 -0400	[thread overview]
Message-ID: <20220816101250.1715523-2-eesposit@redhat.com> (raw)
In-Reply-To: <20220816101250.1715523-1-eesposit@redhat.com>

kvm listeners now need ->commit callback in order to actually send
the ioctl to the hypervisor. Therefore, add missing callers around
address_space_set_flatview(), which in turn calls
address_space_update_topology_pass() which calls ->region_* and
->log_* callbacks.

Using MEMORY_LISTENER_CALL_GLOBAL is a little bit an overkill,
but it is harmless, considering that other listeners that are not
invoked in address_space_update_topology_pass() won't do anything,
since they won't have anything to commit.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
 softmmu/memory.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/softmmu/memory.c b/softmmu/memory.c
index 7ba2048836..1afd3f9703 100644
--- a/softmmu/memory.c
+++ b/softmmu/memory.c
@@ -1076,7 +1076,9 @@ static void address_space_update_topology(AddressSpace *as)
     if (!g_hash_table_lookup(flat_views, physmr)) {
         generate_memory_topology(physmr);
     }
+    MEMORY_LISTENER_CALL_GLOBAL(begin, Forward);
     address_space_set_flatview(as);
+    MEMORY_LISTENER_CALL_GLOBAL(commit, Forward);
 }
 
 void memory_region_transaction_begin(void)
-- 
2.31.1


  reply	other threads:[~2022-08-16 11:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 10:12 [RFC PATCH 0/2] accel/kvm: extend kvm memory listener to support Emanuele Giuseppe Esposito
2022-08-16 10:12 ` Emanuele Giuseppe Esposito [this message]
2022-08-18 19:34   ` [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls Peter Xu
2022-08-26 13:53     ` Emanuele Giuseppe Esposito
2022-08-26 14:13       ` Peter Xu
2022-08-27 21:03         ` Peter Xu
2022-09-09  8:02           ` Emanuele Giuseppe Esposito
2022-08-16 10:12 ` [RFC PATCH 2/2] kvm/kvm-all.c: listener should delay kvm_vm_ioctl to the commit phase Emanuele Giuseppe Esposito
2022-08-18 20:04   ` Peter Xu
2022-08-19  0:55     ` Leonardo Bras Soares Passos
2022-08-22 14:10       ` Peter Xu
2022-08-26 14:07         ` Emanuele Giuseppe Esposito
2022-08-27 20:58           ` Peter Xu
2022-08-30 10:59             ` David Hildenbrand
2022-09-09  8:02               ` Emanuele Giuseppe Esposito
2022-09-09 11:02                 ` David Hildenbrand
2022-09-09  8:00             ` Emanuele Giuseppe Esposito
2022-08-22  9:08   ` Cornelia Huck
2022-08-26 13:53     ` Emanuele Giuseppe Esposito
2022-08-26 14:15   ` David Hildenbrand
2022-08-26 14:32     ` Emanuele Giuseppe Esposito
2022-08-26 14:44       ` David Hildenbrand
2022-09-09  8:04         ` Emanuele Giuseppe Esposito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220816101250.1715523-2-eesposit@redhat.com \
    --to=eesposit@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=kvm@vger.kernel.org \
    --cc=mlevitsk@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox