Re: [kvm-unit-tests PATCH v2 2/2] s390x: create persistent comm-key

Janosch Frank
2022-09-07T06:24:46Z

On 9/6/22 17:31, Nico Boehr wrote:
> Quoting Janosch Frank (2022-09-06 11:50:46)
>> Hmmmmmmm(TM)
>>
>> My first thought was that I'd be pretty angry if the CCK changes on a
>> distclean. But the only scenario where this would matter is when the
>> tests are provided to another system.
>>
>> I'm still a bit torn about deleting the CCK especially as there will
>> always be a CCK in the SE header no matter if we specify one or not.
>
> I really don't have a strong opinion about this. I think it makes sense to clean
> up stuff a Makefile has left behind. But I am honestly just as fine with
> removing this.

Keep it as is, we can still change it when we get complaints. :)