Re: [PATCH v2] vfio: Remove vfio_group dev_counter

[Alex Williamson <alex.williamson@redhat.com>]

On Tue, 16 Aug 2022 16:13:04 -0300
Jason Gunthorpe <jgg@nvidia.com> wrote:

> This counts the number of devices attached to a vfio_group, ie the number
> of items in the group->device_list.
> 
> It is only read in vfio_pin_pages(), as some kind of protection against
> limitations in type1.
> 
> However, with all the code cleanups in this area, now that
> vfio_pin_pages() accepts a vfio_device directly it is redundant.  All
> drivers are already calling vfio_register_emulated_iommu_dev() which
> directly creates a group specifically for the device and thus it is
> guaranteed that there is a singleton group.
> 
> Leave a note in the comment about this requirement and remove the logic.
> 
> Reviewed-by: Yi Liu <yi.l.liu@intel.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  drivers/vfio/vfio_main.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Applied to vfio next branch for v6.1.  Thanks,

Alex