From: kernel test robot <lkp@intel.com>
To: Shivam Kumar <shivam.kumar1@nutanix.com>,
pbonzini@redhat.com, seanjc@google.com, maz@kernel.org,
james.morse@arm.com, borntraeger@linux.ibm.com, david@redhat.com
Cc: kbuild-all@lists.01.org, kvm@vger.kernel.org,
Shivam Kumar <shivam.kumar1@nutanix.com>,
Shaju Abraham <shaju.abraham@nutanix.com>,
Manish Mishra <manish.mishra@nutanix.com>,
Anurag Madnawat <anurag.madnawat@nutanix.com>
Subject: Re: [PATCH v5 1/5] KVM: Implement dirty quota-based throttling of vcpus
Date: Tue, 13 Sep 2022 05:57:09 +0800 [thread overview]
Message-ID: <202209130532.2BJwW65L-lkp@intel.com> (raw)
In-Reply-To: <20220912040926.185481-2-shivam.kumar1@nutanix.com>
Hi Shivam,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kvm/queue]
[also build test WARNING on mst-vhost/linux-next linus/master v6.0-rc5 next-20220912]
[cannot apply to kvms390/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shivam-Kumar/KVM-Dirty-quota-based-throttling/20220912-123509
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
reproduce:
# https://github.com/intel-lab-lkp/linux/commit/772b4ec9f5aee3af7759fe673b6c1e157e7afb8d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Shivam-Kumar/KVM-Dirty-quota-based-throttling/20220912-123509
git checkout 772b4ec9f5aee3af7759fe673b6c1e157e7afb8d
make menuconfig
# enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS
make htmldocs
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> Documentation/virt/kvm/api.rst:6630: WARNING: Block quote ends without a blank line; unexpected unindent.
vim +6630 Documentation/virt/kvm/api.rst
6618
6619 /* KVM_EXIT_DIRTY_QUOTA_EXHAUSTED */
6620 struct {
6621 __u64 count;
6622 __u64 quota;
6623 } dirty_quota_exit;
6624 If exit reason is KVM_EXIT_DIRTY_QUOTA_EXHAUSTED, it indicates that the VCPU has
6625 exhausted its dirty quota. The 'dirty_quota_exit' member of kvm_run structure
6626 makes the following information available to the userspace:
6627 'count' field: the current count of pages dirtied by the VCPU, can be
6628 skewed based on the size of the pages accessed by each vCPU.
6629 'quota' field: the observed dirty quota just before the exit to userspace.
> 6630 The userspace can design a strategy to allocate the overall scope of dirtying
6631 for the VM among the vcpus. Based on the strategy and the current state of dirty
6632 quota throttling, the userspace can make a decision to either update (increase)
6633 the quota or to put the VCPU to sleep for some time.
6634
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-12 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 4:09 [PATCH v5 0/5] KVM: Dirty quota-based throttling Shivam Kumar
2022-09-12 4:09 ` [PATCH v5 1/5] KVM: Implement dirty quota-based throttling of vcpus Shivam Kumar
2022-09-12 21:57 ` kernel test robot [this message]
2022-09-12 4:09 ` [PATCH v5 2/5] KVM: x86: Dirty " Shivam Kumar
2022-09-12 4:09 ` [PATCH v5 3/5] KVM: arm64: " Shivam Kumar
2022-09-12 4:09 ` [PATCH v5 4/5] KVM: s390x: " Shivam Kumar
2022-09-12 4:09 ` [PATCH v5 5/5] KVM: selftests: Add selftests for dirty quota throttling Shivam Kumar
2022-09-12 4:15 ` [PATCH v5 0/5] KVM: Dirty quota-based throttling Shivam Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209130532.2BJwW65L-lkp@intel.com \
--to=lkp@intel.com \
--cc=anurag.madnawat@nutanix.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=james.morse@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=manish.mishra@nutanix.com \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shaju.abraham@nutanix.com \
--cc=shivam.kumar1@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox