From: Jim Mattson <jmattson@google.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Jim Mattson <jmattson@google.com>
Subject: [PATCH v2 0/3] KVM: EFER.LMSLE cleanup
Date: Tue, 20 Sep 2022 13:59:19 -0700 [thread overview]
Message-ID: <20220920205922.1564814-1-jmattson@google.com> (raw)
KVM has never properly virtualized EFER.LMSLE. However, when the
"nested" module parameter is set, KVM lets the guest set EFER.LMSLE.
Ostensibly, this is so that SLES11 Xen 4.0 will boot as a nested
hypervisor.
KVM passes EFER.LMSLE to the hardware through the VMCB, so
the setting works most of the time, but the KVM instruction emulator
completely ignores the bit, so incorrect guest behavior is almost
certainly assured.
With Zen3, AMD has abandoned EFER.LMSLE. KVM still allows it, though, as
long as "nested" is set. However, since the hardware doesn't support it,
the next VMRUN after the emulated WRMSR will fail with "invalid VMCB."
To clean things up, revert the hack that allowed a KVM guest to set
EFER.LMSLE, and enumerate CPUID.80000008H:EDX.EferLmsleUnsupported[bit
20] in KVM_GET_SUPPORTED_CPUID on SVM hosts.
Jim Mattson (3):
Revert "KVM: SVM: Allow EFER.LMSLE to be set with nested svm"
x86/cpufeatures: Introduce X86_FEATURE_NO_LMSLE
KVM: SVM: Unconditionally enumerate EferLmsleUnsupported
arch/x86/include/asm/cpufeatures.h | 1 +
arch/x86/include/asm/msr-index.h | 2 --
arch/x86/kvm/svm/svm.c | 3 ++-
3 files changed, 3 insertions(+), 3 deletions(-)
v1 -> v2: Make no attempt to preserve existing behavior [Sean, Borislav]
--
2.37.3.968.ga6b4b080e4-goog
next reply other threads:[~2022-09-20 20:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 20:59 Jim Mattson [this message]
2022-09-20 20:59 ` [PATCH v2 1/3] Revert "KVM: SVM: Allow EFER.LMSLE to be set with nested svm" Jim Mattson
2022-09-20 20:59 ` [PATCH v2 2/3] x86/cpufeatures: Introduce X86_FEATURE_NO_LMSLE Jim Mattson
2022-09-21 16:07 ` Borislav Petkov
2022-09-20 20:59 ` [PATCH v2 3/3] KVM: SVM: Unconditionally enumerate EferLmsleUnsupported Jim Mattson
2022-10-07 22:41 ` Sean Christopherson
2022-09-20 21:17 ` [PATCH v2 0/3] KVM: EFER.LMSLE cleanup Borislav Petkov
2022-09-20 21:36 ` Sean Christopherson
2022-09-20 21:36 ` Jim Mattson
2022-09-21 9:28 ` Borislav Petkov
2022-09-21 13:45 ` Jim Mattson
2022-09-21 13:54 ` Borislav Petkov
2022-09-21 15:11 ` Jim Mattson
2022-09-21 16:06 ` Borislav Petkov
2022-09-21 16:23 ` Jim Mattson
2022-09-21 17:11 ` Borislav Petkov
2022-09-21 17:45 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920205922.1564814-1-jmattson@google.com \
--to=jmattson@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox