Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>
Cc: kvm@vger.kernel.org, frankja@linux.ibm.com, borntraeger@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v3 0/2] s390x: Add migration test for guest TOD clock
Date: Tue, 11 Oct 2022 19:09:18 +0200	[thread overview]
Message-ID: <20221011190918.182d3001@p-imbrenda> (raw)
In-Reply-To: <20221011170024.972135-1-nrb@linux.ibm.com>

On Tue, 11 Oct 2022 19:00:22 +0200
Nico Boehr <nrb@linux.ibm.com> wrote:

> v2->v3:
> ---
> - check the clock is really set after setting (thanks Claudio)
> - remove unneeded memory clobber (thanks Claudio)
> - add comment to explain what we're testing (thanks Christian)
> 
> v1->v2:
> ---
> - remove unneeded include
> - advance clock by 10 minutes instead of 1 minute (thanks Claudio)
> - express get_clock_us() using stck() (thanks Claudio)
> 
> The guest TOD clock should not go backwards on migration. Add a test to
> verify that.
> 
> To reduce code duplication, move some of the time-related defined
> from the sck test to the library.
> 

thanks, picked

> Nico Boehr (2):
>   lib/s390x: move TOD clock related functions to library
>   s390x: add migration TOD clock test
> 
>  lib/s390x/asm/time.h  | 50 ++++++++++++++++++++++++++++++++++++++-
>  s390x/Makefile        |  1 +
>  s390x/migration-sck.c | 54 +++++++++++++++++++++++++++++++++++++++++++
>  s390x/sck.c           | 32 -------------------------
>  s390x/unittests.cfg   |  4 ++++
>  5 files changed, 108 insertions(+), 33 deletions(-)
>  create mode 100644 s390x/migration-sck.c
> 


      parent reply	other threads:[~2022-10-11 17:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11 17:00 [kvm-unit-tests PATCH v3 0/2] s390x: Add migration test for guest TOD clock Nico Boehr
2022-10-11 17:00 ` [kvm-unit-tests PATCH v3 1/2] lib/s390x: move TOD clock related functions to library Nico Boehr
2022-10-11 17:06   ` Claudio Imbrenda
2022-10-11 17:00 ` [kvm-unit-tests PATCH v3 2/2] s390x: add migration TOD clock test Nico Boehr
2022-10-11 17:07   ` Claudio Imbrenda
2022-10-11 17:09 ` Claudio Imbrenda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011190918.182d3001@p-imbrenda \
    --to=imbrenda@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox