From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642CEC43217 for ; Wed, 12 Oct 2022 22:10:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230174AbiJLWKg (ORCPT ); Wed, 12 Oct 2022 18:10:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbiJLWKP (ORCPT ); Wed, 12 Oct 2022 18:10:15 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCD7E63FF1 for ; Wed, 12 Oct 2022 15:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665612515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e1Csc5OKDLMm08qWQhJj0nFioDDfbxhqyYmrCk7iHHE=; b=i2A1XqpruM38C2MxuNCblSi4VKWwCfcwOF0hN2sqQMWxWzwaa0UJrQeIcMbb3Y2C8w0MCX mXFOKChmkY6fY6nPj4PJtXdCGCHYyLvFaMRpe8YkGc68jhzcOEp6Pa3d5rxalH4FKrRKgs 7bhARNB11lNZ6ssAoYCom7YYeOLv9qM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-191-rIbri7pfMj-Sy3kCWPZnmw-1; Wed, 12 Oct 2022 18:08:33 -0400 X-MC-Unique: rIbri7pfMj-Sy3kCWPZnmw-1 Received: by mail-wm1-f70.google.com with SMTP id r81-20020a1c4454000000b003c41e9ae97dso1779827wma.6 for ; Wed, 12 Oct 2022 15:08:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e1Csc5OKDLMm08qWQhJj0nFioDDfbxhqyYmrCk7iHHE=; b=nSeTczZvvA1V9wo8DwTTChQlGZaAm26oEm1eQMS/EgdmlJOLH0K+gK9qrFAlMIhxHk x8c42S8dh2Sx7GpfKbANfF3oLz5BDjuTLuT4UQ/j5tKhzOjhjdMkqBIMW+fENW0G79X9 s6DQo7SXFH72eYZ+9SipNQDeF+4dWEDDa4c9rP9eXG3gfHP609Qj7lFvftxu85B9nVk8 jyAnxWXxm+bRgHh2IRO5sWHkz+9SAvAAuhuinDHXc78esy86nN4Lgg0gR/brGVj4Hsgw TVmhhUWaMv8/jIMxRN+UdUVPXqwmYrh8lFwU5rt/uwUDQhHJfgZpSiAKktcbp80y5rcx Q2Iw== X-Gm-Message-State: ACrzQf0OxZfKWqagCBWw5Ga2CGUCjd1E2HA0GeNLHZ7DiMdiM/IxiyL3 iD4KgeL2KieHBxL11zdYRu1w1tkPeqRJ9MSaMqZmRU7/BIrvIHXngN8jgrOh54A6A+vB7ovtgJY w9ebMQHXSc6rx X-Received: by 2002:adf:d1cc:0:b0:22e:6371:65ad with SMTP id b12-20020adfd1cc000000b0022e637165admr19590801wrd.326.1665612512757; Wed, 12 Oct 2022 15:08:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Hfapj638ZSQQKBud2DiNS0QJza/l7oyJMq2zEMTl7MZoMYSzTy3MWiISMgB3bUUa2AIbrEw== X-Received: by 2002:adf:d1cc:0:b0:22e:6371:65ad with SMTP id b12-20020adfd1cc000000b0022e637165admr19590785wrd.326.1665612512531; Wed, 12 Oct 2022 15:08:32 -0700 (PDT) Received: from redhat.com ([2.54.162.123]) by smtp.gmail.com with ESMTPSA id a1-20020a05600c348100b003a5f4fccd4asm2812081wmq.35.2022.10.12.15.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 15:08:31 -0700 (PDT) Date: Wed, 12 Oct 2022 18:08:27 -0400 From: "Michael S. Tsirkin" To: Arnd Bergmann Cc: Linus Torvalds , xiujianfeng@huawei.com, kvm@vger.kernel.org, alvaro.karsz@solid-run.com, Jason Wang , angus.chen@jaguarmicro.com, wangdeming@inspur.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, virtualization@lists.linux-foundation.org, Netdev , Bjorn Helgaas , lingshan.zhu@intel.com, linuxppc-dev@lists.ozlabs.org, gavinl@nvidia.com Subject: Re: [GIT PULL] virtio: fixes, features Message-ID: <20221012180806-mutt-send-email-mst@kernel.org> References: <20221010132030-mutt-send-email-mst@kernel.org> <87r0zdmujf.fsf@mpe.ellerman.id.au> <20221012070532-mutt-send-email-mst@kernel.org> <87mta1marq.fsf@mpe.ellerman.id.au> <87edvdm7qg.fsf@mpe.ellerman.id.au> <20221012115023-mutt-send-email-mst@kernel.org> <38893b2e-c7a1-4ad2-b691-7fbcbbeb310f@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38893b2e-c7a1-4ad2-b691-7fbcbbeb310f@app.fastmail.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Oct 12, 2022 at 11:06:54PM +0200, Arnd Bergmann wrote: > On Wed, Oct 12, 2022, at 7:22 PM, Linus Torvalds wrote: > > > > The NO_IRQ thing is mainly actually defined by a few drivers that just > > never got converted to the proper world order, and even then you can > > see the confusion (ie some drivers use "-1", others use "0", and yet > > others use "((unsigned int)(-1)". > > The last time I looked at removing it for arch/arm/, one problem was > that there were a number of platforms using IRQ 0 as a valid number. > We have converted most of them in the meantime, leaving now only > mach-rpc and mach-footbridge. For the other platforms, we just > renumbered all interrupts to add one, but footbridge apparently > relies on hardcoded ISA interrupts in device drivers. For rpc, > it looks like IRQ 0 (printer) already wouldn't work, and it > looks like there was never a driver referencing it either. Do these two boxes even have pci? > I see that openrisc and parisc also still define NO_IRQ to -1, but at > least openrisc already relies on 0 being the invalid IRQ (from > CONFIG_IRQ_DOMAIN), probably parisc as well. > > Arnd