From: Santosh Shukla <santosh.shukla@amd.com>
To: <pbonzini@redhat.com>, <seanjc@google.com>
Cc: <kvm@vger.kernel.org>, <jmattson@google.com>, <joro@8bytes.org>,
<linux-kernel@vger.kernel.org>, <mail@maciej.szmigiero.name>,
<mlevitsk@redhat.com>, <thomas.lendacky@amd.com>,
<vkuznets@redhat.com>
Subject: [PATCHv5 7/8] KVM: nSVM: emulate VMEXIT_INVALID case for nested VNMI
Date: Thu, 27 Oct 2022 14:08:30 +0530 [thread overview]
Message-ID: <20221027083831.2985-8-santosh.shukla@amd.com> (raw)
In-Reply-To: <20221027083831.2985-1-santosh.shukla@amd.com>
If NMI virtualization enabled and NMI_INTERCEPT is unset then next vm
entry will exit with #INVALID exit reason.
In order to emulate above (VMEXIT(#INVALID)) scenario for nested
environment, extending check for V_NMI_ENABLE, NMI_INTERCEPT bit in func
__nested_vmcb_check_controls.
Signed-off-by: Santosh Shukla <santosh.shukla@amd.com>
---
arch/x86/kvm/svm/nested.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c
index d1c22c89427e..e94ec6dee661 100644
--- a/arch/x86/kvm/svm/nested.c
+++ b/arch/x86/kvm/svm/nested.c
@@ -274,6 +274,11 @@ static bool __nested_vmcb_check_controls(struct kvm_vcpu *vcpu,
if (CC(!nested_svm_check_tlb_ctl(vcpu, control->tlb_ctl)))
return false;
+ if (CC((control->int_ctl & V_NMI_ENABLE) &&
+ !vmcb12_is_intercept(control, INTERCEPT_NMI))) {
+ return false;
+ }
+
return true;
}
--
2.25.1
next prev parent reply other threads:[~2022-10-27 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 8:38 [PATCHv5 0/8] Virtual NMI feature Santosh Shukla
2022-10-27 8:38 ` [PATCHv5 1/8] x86/cpu: Add CPUID feature bit for VNMI Santosh Shukla
2022-10-27 8:38 ` [PATCHv5 2/8] KVM: SVM: Add VNMI bit definition Santosh Shukla
2022-10-27 8:38 ` [PATCHv5 3/8] KVM: SVM: Add VNMI support in get/set_nmi_mask Santosh Shukla
2022-10-27 8:38 ` [PATCHv5 4/8] KVM: SVM: Report NMI not allowed when Guest busy handling VNMI Santosh Shukla
2022-10-27 8:38 ` [PATCHv5 5/8] KVM: SVM: Add VNMI support in inject_nmi Santosh Shukla
2022-10-27 8:38 ` [PATCHv5 6/8] KVM: nSVM: implement nested VNMI Santosh Shukla
2022-10-27 8:38 ` Santosh Shukla [this message]
2022-10-27 8:38 ` [PATCHv5 8/8] KVM: SVM: Enable VNMI feature Santosh Shukla
2022-11-14 8:02 ` [PATCHv5 0/8] Virtual NMI feature Santosh Shukla
2022-11-14 14:31 ` Maxim Levitsky
2022-11-16 5:40 ` Santosh Shukla
2022-11-16 9:21 ` Maxim Levitsky
2022-11-16 15:44 ` Santosh Shukla
2022-11-16 15:55 ` Tom Lendacky
2022-11-16 16:59 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027083831.2985-8-santosh.shukla@amd.com \
--to=santosh.shukla@amd.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox