Re: [PATCH 5/6] KVM: x86/VMX: add kvm_vmx_reinject_nmi_irq() for NMI/IRQ reinjection

Peter Zijlstra
2022-11-11T09:19:36Z

On Thu, Nov 10, 2022 at 08:53:09PM +0000, Sean Christopherson wrote:
> On Thu, Nov 10, 2022, Li, Xin3 wrote:

> > > > + * call thus the values in the pt_regs structure are not used in
> > > > + * executing NMI/IRQ handlers,
> > >
> > > Won't this break stack traces to some extent?
> > >
> >
> > The pt_regs structure, and its IP/CS, is NOT part of the call stack, thus
> > I don't see a problem. No?

I'm not sure what Xin3 is trying to say, but NMI/IRQ handers use pt_regs
a *LOT*. pt_regs *MUST* be correct.