* [PATCH v2] s390/vfio-ap: GISA: sort out physical vs virtual pointers usage
@ 2022-11-18 10:04 Nico Boehr
2022-11-18 10:43 ` Claudio Imbrenda
0 siblings, 1 reply; 2+ messages in thread
From: Nico Boehr @ 2022-11-18 10:04 UTC (permalink / raw)
To: pasic, akrowiak, jjherne; +Cc: linux-s390, kvm, borntraeger, frankja, imbrenda
Fix virtual vs physical address confusion (which currently are the same)
for the GISA when enabling the IRQ.
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
---
v1->v2:
* remove useless cast
drivers/s390/crypto/vfio_ap_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
index 0b4cc8c597ae..205a00105858 100644
--- a/drivers/s390/crypto/vfio_ap_ops.c
+++ b/drivers/s390/crypto/vfio_ap_ops.c
@@ -429,7 +429,7 @@ static struct ap_queue_status vfio_ap_irq_enable(struct vfio_ap_queue *q,
aqic_gisa.isc = nisc;
aqic_gisa.ir = 1;
- aqic_gisa.gisa = (uint64_t)gisa >> 4;
+ aqic_gisa.gisa = virt_to_phys(gisa) >> 4;
status = ap_aqic(q->apqn, aqic_gisa, h_nib);
switch (status.response_code) {
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] s390/vfio-ap: GISA: sort out physical vs virtual pointers usage
2022-11-18 10:04 [PATCH v2] s390/vfio-ap: GISA: sort out physical vs virtual pointers usage Nico Boehr
@ 2022-11-18 10:43 ` Claudio Imbrenda
0 siblings, 0 replies; 2+ messages in thread
From: Claudio Imbrenda @ 2022-11-18 10:43 UTC (permalink / raw)
To: Nico Boehr
Cc: pasic, akrowiak, jjherne, linux-s390, kvm, borntraeger, frankja
On Fri, 18 Nov 2022 11:04:29 +0100
Nico Boehr <nrb@linux.ibm.com> wrote:
> Fix virtual vs physical address confusion (which currently are the same)
> for the GISA when enabling the IRQ.
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> v1->v2:
> * remove useless cast
>
> drivers/s390/crypto/vfio_ap_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> index 0b4cc8c597ae..205a00105858 100644
> --- a/drivers/s390/crypto/vfio_ap_ops.c
> +++ b/drivers/s390/crypto/vfio_ap_ops.c
> @@ -429,7 +429,7 @@ static struct ap_queue_status vfio_ap_irq_enable(struct vfio_ap_queue *q,
>
> aqic_gisa.isc = nisc;
> aqic_gisa.ir = 1;
> - aqic_gisa.gisa = (uint64_t)gisa >> 4;
> + aqic_gisa.gisa = virt_to_phys(gisa) >> 4;
>
> status = ap_aqic(q->apqn, aqic_gisa, h_nib);
> switch (status.response_code) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-18 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-18 10:04 [PATCH v2] s390/vfio-ap: GISA: sort out physical vs virtual pointers usage Nico Boehr
2022-11-18 10:43 ` Claudio Imbrenda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox