* [PATCH] KVM: s390: remove unused gisa_clear_ipm_gisc() function
@ 2022-11-18 15:11 Heiko Carstens
2022-11-18 15:56 ` Thomas Huth
2022-11-21 12:07 ` Christian Borntraeger
0 siblings, 2 replies; 3+ messages in thread
From: Heiko Carstens @ 2022-11-18 15:11 UTC (permalink / raw)
To: Christian Borntraeger, Janosch Frank, Claudio Imbrenda
Cc: David Hildenbrand, kvm, linux-s390
clang warns about an unused function:
arch/s390/kvm/interrupt.c:317:20:
error: unused function 'gisa_clear_ipm_gisc' [-Werror,-Wunused-function]
static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
Remove gisa_clear_ipm_gisc(), since it is unused and get rid of this
warning.
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
arch/s390/kvm/interrupt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index ab569faf0df2..1dae78deddf2 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -314,11 +314,6 @@ static inline u8 gisa_get_ipm(struct kvm_s390_gisa *gisa)
return READ_ONCE(gisa->ipm);
}
-static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
-{
- clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
-}
-
static inline int gisa_tac_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
{
return test_and_clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: s390: remove unused gisa_clear_ipm_gisc() function
2022-11-18 15:11 [PATCH] KVM: s390: remove unused gisa_clear_ipm_gisc() function Heiko Carstens
@ 2022-11-18 15:56 ` Thomas Huth
2022-11-21 12:07 ` Christian Borntraeger
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2022-11-18 15:56 UTC (permalink / raw)
To: Heiko Carstens, Christian Borntraeger, Janosch Frank,
Claudio Imbrenda, Michael Mueller
Cc: David Hildenbrand, kvm, linux-s390
On 18/11/2022 16.11, Heiko Carstens wrote:
> clang warns about an unused function:
> arch/s390/kvm/interrupt.c:317:20:
> error: unused function 'gisa_clear_ipm_gisc' [-Werror,-Wunused-function]
> static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
>
> Remove gisa_clear_ipm_gisc(), since it is unused and get rid of this
> warning.
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> arch/s390/kvm/interrupt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index ab569faf0df2..1dae78deddf2 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -314,11 +314,6 @@ static inline u8 gisa_get_ipm(struct kvm_s390_gisa *gisa)
> return READ_ONCE(gisa->ipm);
> }
>
> -static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
> -{
> - clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
> -}
Unused since its introduction in commit d77e64141e322.
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: s390: remove unused gisa_clear_ipm_gisc() function
2022-11-18 15:11 [PATCH] KVM: s390: remove unused gisa_clear_ipm_gisc() function Heiko Carstens
2022-11-18 15:56 ` Thomas Huth
@ 2022-11-21 12:07 ` Christian Borntraeger
1 sibling, 0 replies; 3+ messages in thread
From: Christian Borntraeger @ 2022-11-21 12:07 UTC (permalink / raw)
To: Heiko Carstens, Janosch Frank, Claudio Imbrenda
Cc: David Hildenbrand, kvm, linux-s390
Am 18.11.22 um 16:11 schrieb Heiko Carstens:
> clang warns about an unused function:
> arch/s390/kvm/interrupt.c:317:20:
> error: unused function 'gisa_clear_ipm_gisc' [-Werror,-Wunused-function]
> static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
>
> Remove gisa_clear_ipm_gisc(), since it is unused and get rid of this
> warning.
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Thanks, queued.
> ---
> arch/s390/kvm/interrupt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index ab569faf0df2..1dae78deddf2 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -314,11 +314,6 @@ static inline u8 gisa_get_ipm(struct kvm_s390_gisa *gisa)
> return READ_ONCE(gisa->ipm);
> }
>
> -static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
> -{
> - clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
> -}
> -
> static inline int gisa_tac_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
> {
> return test_and_clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-21 12:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-18 15:11 [PATCH] KVM: s390: remove unused gisa_clear_ipm_gisc() function Heiko Carstens
2022-11-18 15:56 ` Thomas Huth
2022-11-21 12:07 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox