Re: [kvm-unit-tests PATCH v1 1/4] lib: add function to request migration

Nico Boehr
2022-12-01T08:13:02Z

Quoting Claudio Imbrenda (2022-11-30 18:30:06)
> On Wed, 30 Nov 2022 15:22:46 +0100
> Nico Boehr <nrb@linux.ibm.com> wrote:
[...]
> > diff --git a/lib/migrate.c b/lib/migrate.c
> > new file mode 100644
> > index 000000000000..50e78fb08865
> > --- /dev/null
> > +++ b/lib/migrate.c
> > @@ -0,0 +1,34 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Migration-related functions
> > + *
> > + * Copyright IBM Corp. 2022
> > + * Author: Nico Boehr <nrb@linux.ibm.com>
> > + */
> > +#include <libcflat.h>
> > +#include "migrate.h"
> > +
> > +/* static for now since we only support migrating exactly once per test. */
> > +static void migrate(void)
> > +{
> > + puts("Please migrate me, then press return\n");
>
> the other architectures use a slightly different message, maybe we
> should use that also on s390x?
>
> In the end it _should_ not matter, since the migrate_cmd looks for one
> specific keyword, but I still think we should try to minimize the
> impact of this series. And I know that changing the migration message
> will not break anything on s390x.

Oh yes, that's a very good point. Changed.