Re: [kvm-unit-tests PATCH v1 4/4] arm: use migrate_once() in migration tests

Nico Boehr
2022-12-09T12:56:48Z

Quoting Andrew Jones (2022-12-02 12:56:58)
> On Wed, Nov 30, 2022 at 03:22:49PM +0100, Nico Boehr wrote:
> > Some tests already shipped with their own do_migrate() function, remove
> > it and instead use the new migrate_once() function. The control flow in
> > the gib tests can be simplified due to migrate_once().
>
> s/gib/gic/

Opsie, thanks :)

[...]
> > diff --git a/arm/debug.c b/arm/debug.c
> > index e9f805632db7..21b0f5aeb590 100644
> > --- a/arm/debug.c
> > +++ b/arm/debug.c
[...]
> > @@ -369,7 +363,7 @@ static noinline void test_ss(bool migrate)
> > isb();
> >
> > if (migrate) {
> > - do_migrate();
> > + migrate_once();
> > }
>
> While here, please opportunistically drop the unnecessary {}

Done.

[...]
> Reviewed-by: Andrew Jones <andrew.jones@linux.dev>

Thanks.