From: coverity-bot <keescook@chromium.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Coverity: kvm_hv_flush_tlb(): Uninitialized variables
Date: Thu, 1 Dec 2022 08:25:41 -0800 [thread overview]
Message-ID: <202212010825.9FB75F1F@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221201 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Fri Nov 18 12:59:05 2022 -0500
260970862c88 ("KVM: x86: hyper-v: Handle HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} calls gently")
Coverity reported the following:
*** CID 1527764: Uninitialized variables (UNINIT)
arch/x86/kvm/hyperv.c:2024 in kvm_hv_flush_tlb()
2018 * Hyper-V TLFS doesn't explicitly forbid non-empty sparse vCPU
2019 * banks (and, thus, non-zero 'var_cnt') for the 'all vCPUs'
2020 * case (HV_GENERIC_SET_ALL). Always adjust data_offset and
2021 * consumed_xmm_halves to make sure TLB flush entries are read
2022 * from the correct offset.
2023 */
vvv CID 1527764: Uninitialized variables (UNINIT)
vvv Using uninitialized value "data_offset".
2024 data_offset += hc->var_cnt * sizeof(sparse_banks[0]);
2025 consumed_xmm_halves += hc->var_cnt;
2026 }
2027
2028 if (hc->code == HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE ||
2029 hc->code == HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE_EX ||
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1527764 ("Uninitialized variables")
Fixes: 260970862c88 ("KVM: x86: hyper-v: Handle HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} calls gently")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2022-12-01 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 16:25 coverity-bot [this message]
2022-12-01 16:45 ` Coverity: kvm_hv_flush_tlb(): Uninitialized variables Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212010825.9FB75F1F@keescook \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox