From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE37EC352A1 for ; Tue, 6 Dec 2022 06:19:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233661AbiLFGTt (ORCPT ); Tue, 6 Dec 2022 01:19:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231978AbiLFGTr (ORCPT ); Tue, 6 Dec 2022 01:19:47 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FE8224F28; Mon, 5 Dec 2022 22:19:46 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 051516732D; Tue, 6 Dec 2022 07:19:41 +0100 (CET) Date: Tue, 6 Dec 2022 07:19:40 +0100 From: Christoph Hellwig To: Lei Rao Cc: kbusch@kernel.org, axboe@fb.com, kch@nvidia.com, hch@lst.de, sagi@grimberg.me, alex.williamson@redhat.com, cohuck@redhat.com, jgg@ziepe.ca, yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com, mjrosato@linux.ibm.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, kvm@vger.kernel.org, eddie.dong@intel.com, yadong.li@intel.com, yi.l.liu@intel.com, Konrad.wilk@oracle.com, stephen@eideticom.com, hang.yuan@intel.com Subject: Re: [RFC PATCH 1/5] nvme-pci: add function nvme_submit_vf_cmd to issue admin commands for VF driver. Message-ID: <20221206061940.GA6595@lst.de> References: <20221206055816.292304-1-lei.rao@intel.com> <20221206055816.292304-2-lei.rao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206055816.292304-2-lei.rao@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Dec 06, 2022 at 01:58:12PM +0800, Lei Rao wrote: > The new function nvme_submit_vf_cmd() helps the host VF driver to issue > VF admin commands. It's helpful in some cases that the host NVMe driver > does not control VF's admin queue. For example, in the virtualization > device pass-through case, the VF controller's admin queue is governed > by the Guest NVMe driver. Host VF driver relies on PF device's admin > queue to control VF devices like vendor-specific live migration commands. WTF are you even smoking when you think this would be acceptable?