From: Robert Hoo <robert.hu@linux.intel.com>
To: pbonzini@redhat.com, seanjc@google.com,
kirill.shutemov@linux.intel.com, kvm@vger.kernel.org
Cc: Robert Hoo <robert.hu@linux.intel.com>,
Jingqi Liu <jingqi.liu@intel.com>
Subject: [PATCH v3 3/9] KVM: x86: MMU: Rename get_cr3() --> get_pgd() and clear high bits for pgd
Date: Fri, 9 Dec 2022 12:45:51 +0800 [thread overview]
Message-ID: <20221209044557.1496580-4-robert.hu@linux.intel.com> (raw)
In-Reply-To: <20221209044557.1496580-1-robert.hu@linux.intel.com>
The get_cr3() is the implementation of kvm_mmu::get_guest_pgd(), well, CR3
cannot be naturally equivalent to pgd, SDM says CR3 high bits are reserved,
must be zero.
And now, with LAM feature's introduction, bit 61 ~ 62 are used.
So, rename get_cr3() --> get_pgd() to better indicate function purpose and
in it, filtered out CR3 high bits.
Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
Reviewed-by: Jingqi Liu <jingqi.liu@intel.com>
---
arch/x86/include/asm/processor-flags.h | 1 +
arch/x86/kvm/mmu/mmu.c | 12 ++++++++----
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/processor-flags.h b/arch/x86/include/asm/processor-flags.h
index d8cccadc83a6..bb0f8dd16956 100644
--- a/arch/x86/include/asm/processor-flags.h
+++ b/arch/x86/include/asm/processor-flags.h
@@ -38,6 +38,7 @@
#ifdef CONFIG_X86_64
/* Mask off the address space ID and SME encryption bits. */
#define CR3_ADDR_MASK __sme_clr(PHYSICAL_PAGE_MASK)
+#define CR3_HIGH_RSVD_MASK GENMASK_ULL(63, 52)
#define CR3_PCID_MASK 0xFFFull
#define CR3_NOFLUSH BIT_ULL(63)
diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
index b6f96d47e596..d433c8923b18 100644
--- a/arch/x86/kvm/mmu/mmu.c
+++ b/arch/x86/kvm/mmu/mmu.c
@@ -4488,9 +4488,13 @@ void kvm_mmu_new_pgd(struct kvm_vcpu *vcpu, gpa_t new_pgd)
}
EXPORT_SYMBOL_GPL(kvm_mmu_new_pgd);
-static unsigned long get_cr3(struct kvm_vcpu *vcpu)
+static unsigned long get_pgd(struct kvm_vcpu *vcpu)
{
+#ifdef CONFIG_X86_64
+ return kvm_read_cr3(vcpu) & ~CR3_HIGH_RSVD_MASK;
+#else
return kvm_read_cr3(vcpu);
+#endif
}
static bool sync_mmio_spte(struct kvm_vcpu *vcpu, u64 *sptep, gfn_t gfn,
@@ -5043,7 +5047,7 @@ static void init_kvm_tdp_mmu(struct kvm_vcpu *vcpu,
context->page_fault = kvm_tdp_page_fault;
context->sync_page = nonpaging_sync_page;
context->invlpg = NULL;
- context->get_guest_pgd = get_cr3;
+ context->get_guest_pgd = get_pgd;
context->get_pdptr = kvm_pdptr_read;
context->inject_page_fault = kvm_inject_page_fault;
@@ -5193,7 +5197,7 @@ static void init_kvm_softmmu(struct kvm_vcpu *vcpu,
kvm_init_shadow_mmu(vcpu, cpu_role);
- context->get_guest_pgd = get_cr3;
+ context->get_guest_pgd = get_pgd;
context->get_pdptr = kvm_pdptr_read;
context->inject_page_fault = kvm_inject_page_fault;
}
@@ -5207,7 +5211,7 @@ static void init_kvm_nested_mmu(struct kvm_vcpu *vcpu,
return;
g_context->cpu_role.as_u64 = new_mode.as_u64;
- g_context->get_guest_pgd = get_cr3;
+ g_context->get_guest_pgd = get_pgd;
g_context->get_pdptr = kvm_pdptr_read;
g_context->inject_page_fault = kvm_inject_page_fault;
--
2.31.1
next prev parent reply other threads:[~2022-12-09 4:46 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 4:45 [PATCH v3 0/9] Linear Address Masking (LAM) KVM Enabling Robert Hoo
2022-12-09 4:45 ` [PATCH v3 1/9] KVM: x86: Rename cr4_reserved/rsvd_* variables to be more readable Robert Hoo
2022-12-28 3:37 ` Binbin Wu
2022-12-29 1:42 ` Robert Hoo
2023-01-07 0:35 ` Sean Christopherson
2023-01-07 13:30 ` Robert Hoo
2023-01-08 14:18 ` Xiaoyao Li
2023-01-09 3:07 ` Robert Hoo
2022-12-09 4:45 ` [PATCH v3 2/9] KVM: x86: Add CR4.LAM_SUP in guest owned bits Robert Hoo
2023-01-07 0:38 ` Sean Christopherson
2023-01-07 13:32 ` Robert Hoo
2023-01-09 16:29 ` Sean Christopherson
2023-01-10 3:56 ` Robert Hoo
2023-01-11 17:35 ` Sean Christopherson
2022-12-09 4:45 ` Robert Hoo [this message]
2022-12-19 6:44 ` [PATCH v3 3/9] KVM: x86: MMU: Rename get_cr3() --> get_pgd() and clear high bits for pgd Yuan Yao
2022-12-20 14:07 ` Robert Hoo
2023-01-07 0:45 ` Sean Christopherson
2023-01-07 13:36 ` Robert Hoo
2022-12-09 4:45 ` [PATCH v3 4/9] KVM: x86: MMU: Commets update Robert Hoo
2022-12-09 4:45 ` [PATCH v3 5/9] KVM: x86: MMU: Integrate LAM bits when build guest CR3 Robert Hoo
2022-12-19 6:53 ` Yuan Yao
2022-12-20 14:07 ` Robert Hoo
2022-12-21 2:12 ` Yuan Yao
2022-12-21 7:50 ` Yu Zhang
2022-12-21 8:55 ` Robert Hoo
2022-12-09 4:45 ` [PATCH v3 6/9] KVM: x86: Untag LAM bits when applicable Robert Hoo
2022-12-19 7:32 ` Yuan Yao
2022-12-20 14:07 ` Robert Hoo
2022-12-19 9:45 ` Yuan Yao
2022-12-20 14:07 ` Robert Hoo
2022-12-21 2:38 ` Yuan Yao
2022-12-21 8:02 ` Yu Zhang
2022-12-21 8:49 ` Robert Hoo
2022-12-21 10:10 ` Yu Zhang
2022-12-21 10:30 ` Yuan Yao
2022-12-21 12:40 ` Yu Zhang
2022-12-22 8:21 ` Yu Zhang
2022-12-23 2:36 ` Yuan Yao
2022-12-23 3:55 ` Robert Hoo
2022-12-21 0:35 ` Yang, Weijiang
2022-12-21 1:38 ` Robert Hoo
2022-12-21 2:55 ` Yuan Yao
2022-12-21 8:22 ` Robert Hoo
2022-12-21 9:35 ` Yuan Yao
2022-12-21 10:22 ` Yu Zhang
2022-12-21 10:33 ` Yuan Yao
2022-12-21 8:14 ` Yu Zhang
2022-12-21 8:37 ` Yu Zhang
2022-12-28 8:32 ` Binbin Wu
2022-12-29 0:41 ` Robert Hoo
2022-12-09 4:45 ` [PATCH v3 7/9] KVM: x86: When judging setting CR3 valid or not, consider LAM bits Robert Hoo
2022-12-09 4:45 ` [PATCH v3 8/9] KVM: x86: When guest set CR3, handle LAM bits semantics Robert Hoo
2022-12-20 9:10 ` Liu, Jingqi
2022-12-20 14:16 ` Robert Hoo
2022-12-21 8:30 ` Yu Zhang
2022-12-21 12:52 ` Robert Hoo
2022-12-09 4:45 ` [PATCH v3 9/9] KVM: x86: LAM: Expose LAM CPUID to user space VMM Robert Hoo
2022-12-19 6:12 ` [PATCH v3 0/9] Linear Address Masking (LAM) KVM Enabling Robert Hoo
2022-12-19 8:09 ` Yuan Yao
2022-12-20 14:06 ` Robert Hoo
2022-12-20 9:20 ` Liu, Jingqi
2022-12-20 14:19 ` Robert Hoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209044557.1496580-4-robert.hu@linux.intel.com \
--to=robert.hu@linux.intel.com \
--cc=jingqi.liu@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox