public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Hoo <robert.hu@linux.intel.com>
To: pbonzini@redhat.com, seanjc@google.com,
	kirill.shutemov@linux.intel.com, kvm@vger.kernel.org
Cc: Robert Hoo <robert.hu@linux.intel.com>,
	Jingqi Liu <jingqi.liu@intel.com>
Subject: [PATCH v3 7/9] KVM: x86: When judging setting CR3 valid or not, consider LAM bits
Date: Fri,  9 Dec 2022 12:45:55 +0800	[thread overview]
Message-ID: <20221209044557.1496580-8-robert.hu@linux.intel.com> (raw)
In-Reply-To: <20221209044557.1496580-1-robert.hu@linux.intel.com>

Before apply to kvm_vcpu_is_illegal_gpa(), clear LAM bits if it's valid.

Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
Reviewed-by: Jingqi Liu <jingqi.liu@intel.com>
---
 arch/x86/kvm/x86.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 0a446b45e3d6..48a2ad1e4cd6 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1237,6 +1237,14 @@ static void kvm_invalidate_pcid(struct kvm_vcpu *vcpu, unsigned long pcid)
 	kvm_mmu_free_roots(vcpu->kvm, mmu, roots_to_free);
 }
 
+static bool kvm_is_valid_cr3(struct kvm_vcpu *vcpu, unsigned long cr3)
+{
+	if (guest_cpuid_has(vcpu, X86_FEATURE_LAM))
+		cr3 &= ~(X86_CR3_LAM_U48 | X86_CR3_LAM_U57);
+
+	return kvm_vcpu_is_legal_gpa(vcpu, cr3);
+}
+
 int kvm_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3)
 {
 	bool skip_tlb_flush = false;
@@ -1260,7 +1268,7 @@ int kvm_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3)
 	 * stuff CR3, e.g. for RSM emulation, and there is no guarantee that
 	 * the current vCPU mode is accurate.
 	 */
-	if (kvm_vcpu_is_illegal_gpa(vcpu, cr3))
+	if (!kvm_is_valid_cr3(vcpu, cr3))
 		return 1;
 
 	if (is_pae_paging(vcpu) && !load_pdptrs(vcpu, cr3))
-- 
2.31.1


  parent reply	other threads:[~2022-12-09  4:46 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09  4:45 [PATCH v3 0/9] Linear Address Masking (LAM) KVM Enabling Robert Hoo
2022-12-09  4:45 ` [PATCH v3 1/9] KVM: x86: Rename cr4_reserved/rsvd_* variables to be more readable Robert Hoo
2022-12-28  3:37   ` Binbin Wu
2022-12-29  1:42     ` Robert Hoo
2023-01-07  0:35       ` Sean Christopherson
2023-01-07 13:30         ` Robert Hoo
2023-01-08 14:18           ` Xiaoyao Li
2023-01-09  3:07             ` Robert Hoo
2022-12-09  4:45 ` [PATCH v3 2/9] KVM: x86: Add CR4.LAM_SUP in guest owned bits Robert Hoo
2023-01-07  0:38   ` Sean Christopherson
2023-01-07 13:32     ` Robert Hoo
2023-01-09 16:29       ` Sean Christopherson
2023-01-10  3:56         ` Robert Hoo
2023-01-11 17:35           ` Sean Christopherson
2022-12-09  4:45 ` [PATCH v3 3/9] KVM: x86: MMU: Rename get_cr3() --> get_pgd() and clear high bits for pgd Robert Hoo
2022-12-19  6:44   ` Yuan Yao
2022-12-20 14:07     ` Robert Hoo
2023-01-07  0:45   ` Sean Christopherson
2023-01-07 13:36     ` Robert Hoo
2022-12-09  4:45 ` [PATCH v3 4/9] KVM: x86: MMU: Commets update Robert Hoo
2022-12-09  4:45 ` [PATCH v3 5/9] KVM: x86: MMU: Integrate LAM bits when build guest CR3 Robert Hoo
2022-12-19  6:53   ` Yuan Yao
2022-12-20 14:07     ` Robert Hoo
2022-12-21  2:12       ` Yuan Yao
2022-12-21  7:50       ` Yu Zhang
2022-12-21  8:55         ` Robert Hoo
2022-12-09  4:45 ` [PATCH v3 6/9] KVM: x86: Untag LAM bits when applicable Robert Hoo
2022-12-19  7:32   ` Yuan Yao
2022-12-20 14:07     ` Robert Hoo
2022-12-19  9:45   ` Yuan Yao
2022-12-20 14:07     ` Robert Hoo
2022-12-21  2:38       ` Yuan Yao
2022-12-21  8:02       ` Yu Zhang
2022-12-21  8:49         ` Robert Hoo
2022-12-21 10:10           ` Yu Zhang
2022-12-21 10:30             ` Yuan Yao
2022-12-21 12:40               ` Yu Zhang
2022-12-22  8:21                 ` Yu Zhang
2022-12-23  2:36                   ` Yuan Yao
2022-12-23  3:55                     ` Robert Hoo
2022-12-21  0:35   ` Yang, Weijiang
2022-12-21  1:38     ` Robert Hoo
2022-12-21  2:55   ` Yuan Yao
2022-12-21  8:22     ` Robert Hoo
2022-12-21  9:35       ` Yuan Yao
2022-12-21 10:22         ` Yu Zhang
2022-12-21 10:33           ` Yuan Yao
2022-12-21  8:14   ` Yu Zhang
2022-12-21  8:37     ` Yu Zhang
2022-12-28  8:32   ` Binbin Wu
2022-12-29  0:41     ` Robert Hoo
2022-12-09  4:45 ` Robert Hoo [this message]
2022-12-09  4:45 ` [PATCH v3 8/9] KVM: x86: When guest set CR3, handle LAM bits semantics Robert Hoo
2022-12-20  9:10   ` Liu, Jingqi
2022-12-20 14:16     ` Robert Hoo
2022-12-21  8:30   ` Yu Zhang
2022-12-21 12:52     ` Robert Hoo
2022-12-09  4:45 ` [PATCH v3 9/9] KVM: x86: LAM: Expose LAM CPUID to user space VMM Robert Hoo
2022-12-19  6:12 ` [PATCH v3 0/9] Linear Address Masking (LAM) KVM Enabling Robert Hoo
2022-12-19  8:09 ` Yuan Yao
2022-12-20 14:06   ` Robert Hoo
2022-12-20  9:20 ` Liu, Jingqi
2022-12-20 14:19   ` Robert Hoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221209044557.1496580-8-robert.hu@linux.intel.com \
    --to=robert.hu@linux.intel.com \
    --cc=jingqi.liu@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox