From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C33DC4167B for ; Mon, 26 Dec 2022 18:41:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232147AbiLZSlQ (ORCPT ); Mon, 26 Dec 2022 13:41:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbiLZSlP (ORCPT ); Mon, 26 Dec 2022 13:41:15 -0500 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D4E4BBF for ; Mon, 26 Dec 2022 10:41:14 -0800 (PST) Date: Mon, 26 Dec 2022 19:41:12 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1672080073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GK1wlfneBKx/1y+grM7PObZo37/OgfH4wx0X7LSzWSA=; b=g54L9gGYnCDLdSqZRZii0mK/vaU3H9xsw11J47QJ2caSE06sX5Y3k7wEAnECcKZzWjvR0m qZuegGN/MgXkW9DjKC+stl1iILmpfNMUAP6k0d5CPbOQADw/NkrS02mGWWfiEvoPFY2TB3 tQc8qClsRjfBQPLUtHpcevIw9FRr1Oo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Nico Boehr Cc: Claudio Imbrenda , kvm@vger.kernel.org, frankja@linux.ibm.com, seiden@linux.ibm.com, nsg@linux.ibm.com, thuth@redhat.com Subject: Re: [kvm-unit-tests PATCH v1 1/1] s390x: fix make standalone Message-ID: <20221226184112.ezyw2imr2ezffutr@orel> References: <20221220175508.57180-1-imbrenda@linux.ibm.com> <167161061144.28055.8565976183630294954@t14-nrb.local> <167161409237.28055.17477704571322735500@t14-nrb.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167161409237.28055.17477704571322735500@t14-nrb.local> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Dec 21, 2022 at 10:14:52AM +0100, Nico Boehr wrote: > Quoting Nico Boehr (2022-12-21 09:16:51) > > Quoting Claudio Imbrenda (2022-12-20 18:55:08) > > > A recent patch broke make standalone. The function find_word is not > > > available when running make standalone, replace it with a simple grep. > > > > > > Reported-by: Nina Schoetterl-Glausch > > > Fixes: 743cacf7 ("s390x: don't run migration tests under PV") > > > Signed-off-by: Claudio Imbrenda > > > > I am confused why find_word would not be available in standalone, since run() in runtime.bash uses it quite a few times. > > > > Not that I mind the grep, but I fear more might be broken in standalone? standalone tests don't currently include scripts/$ARCH/func.bash, which may be an issue for s390x. That could be fixed, though. > > > > Anyways, to get this fixed ASAP: > > > > Acked-by: Nico Boehr > > OK, I get it now, find_word is not available during _build time_. That could be changed, but it'd need to be moved to somewhere that mkstandalone.sh wants to source, which could be common.bash, but then we'd need to include common.bash in the standalone tests. So, a new file for find_word() would be cleaner, but that sounds like overkill. Thanks, drew > > Please make this a: > > Reviewed-by: Nico Boehr