From: Shunsuke Mie <mie@igel.co.jp>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Shunsuke Mie <mie@igel.co.jp>
Subject: [RFC PATCH 6/9] caif_virtio: convert to new unified vringh APIs
Date: Tue, 27 Dec 2022 11:25:28 +0900 [thread overview]
Message-ID: <20221227022528.609839-7-mie@igel.co.jp> (raw)
In-Reply-To: <20221227022528.609839-1-mie@igel.co.jp>
vringh_*_kern APIs are being removed without vringh_init_kern(), so change
to use new APIs.
Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
---
drivers/net/caif/caif_virtio.c | 26 ++++++++++----------------
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c
index 0b0f234b0b50..f9dd79807afa 100644
--- a/drivers/net/caif/caif_virtio.c
+++ b/drivers/net/caif/caif_virtio.c
@@ -265,18 +265,12 @@ static int cfv_rx_poll(struct napi_struct *napi, int quota)
*/
if (riov->i == riov->used) {
if (cfv->ctx.head != USHRT_MAX) {
- vringh_complete_kern(cfv->vr_rx,
- cfv->ctx.head,
- 0);
+ vringh_complete(cfv->vr_rx, cfv->ctx.head, 0);
cfv->ctx.head = USHRT_MAX;
}
- err = vringh_getdesc_kern(
- cfv->vr_rx,
- riov,
- NULL,
- &cfv->ctx.head,
- GFP_ATOMIC);
+ err = vringh_getdesc(cfv->vr_rx, riov, NULL,
+ &cfv->ctx.head);
if (err <= 0)
goto exit;
@@ -317,9 +311,9 @@ static int cfv_rx_poll(struct napi_struct *napi, int quota)
/* Really out of packets? (stolen from virtio_net)*/
napi_complete(napi);
- if (unlikely(!vringh_notify_enable_kern(cfv->vr_rx)) &&
+ if (unlikely(!vringh_notify_enable(cfv->vr_rx)) &&
napi_schedule_prep(napi)) {
- vringh_notify_disable_kern(cfv->vr_rx);
+ vringh_notify_disable(cfv->vr_rx);
__napi_schedule(napi);
}
break;
@@ -329,7 +323,7 @@ static int cfv_rx_poll(struct napi_struct *napi, int quota)
dev_kfree_skb(skb);
/* Stop NAPI poll on OOM, we hope to be polled later */
napi_complete(napi);
- vringh_notify_enable_kern(cfv->vr_rx);
+ vringh_notify_enable(cfv->vr_rx);
break;
default:
@@ -337,12 +331,12 @@ static int cfv_rx_poll(struct napi_struct *napi, int quota)
netdev_warn(cfv->ndev, "Bad ring, disable device\n");
cfv->ndev->stats.rx_dropped = riov->used - riov->i;
napi_complete(napi);
- vringh_notify_disable_kern(cfv->vr_rx);
+ vringh_notify_disable(cfv->vr_rx);
netif_carrier_off(cfv->ndev);
break;
}
out:
- if (rxcnt && vringh_need_notify_kern(cfv->vr_rx) > 0)
+ if (rxcnt && vringh_need_notify(cfv->vr_rx) > 0)
vringh_notify(cfv->vr_rx);
return rxcnt;
}
@@ -352,7 +346,7 @@ static void cfv_recv(struct virtio_device *vdev, struct vringh *vr_rx)
struct cfv_info *cfv = vdev->priv;
++cfv->stats.rx_kicks;
- vringh_notify_disable_kern(cfv->vr_rx);
+ vringh_notify_disable(cfv->vr_rx);
napi_schedule(&cfv->napi);
}
@@ -460,7 +454,7 @@ static int cfv_netdev_close(struct net_device *netdev)
/* Disable interrupts, queues and NAPI polling */
netif_carrier_off(netdev);
virtqueue_disable_cb(cfv->vq_tx);
- vringh_notify_disable_kern(cfv->vr_rx);
+ vringh_notify_disable(cfv->vr_rx);
napi_disable(&cfv->napi);
/* Release any TX buffers on both used and available rings */
--
2.25.1
prev parent reply other threads:[~2022-12-27 2:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 2:25 [RFC PATCH 0/6] Introduce a vringh accessor for IO memory Shunsuke Mie
2022-12-27 2:25 ` [RFC PATCH 1/9] vringh: fix a typo in comments for vringh_kiov Shunsuke Mie
2022-12-27 2:25 ` [RFC PATCH 2/9] vringh: remove vringh_iov and unite to vringh_kiov Shunsuke Mie
2022-12-27 6:04 ` Jason Wang
2022-12-27 7:05 ` Michael S. Tsirkin
2022-12-27 7:13 ` Shunsuke Mie
2022-12-27 7:56 ` Michael S. Tsirkin
2022-12-27 7:57 ` Shunsuke Mie
2022-12-27 7:05 ` Shunsuke Mie
2022-12-28 6:36 ` Jason Wang
2023-01-11 3:26 ` Shunsuke Mie
2023-01-11 5:54 ` Jason Wang
2023-01-11 6:19 ` Shunsuke Mie
2022-12-27 2:25 ` [RFC PATCH 3/9] tools/virtio: convert to new vringh user APIs Shunsuke Mie
2022-12-27 2:25 ` [RFC PATCH 4/9] vringh: unify the APIs for all accessors Shunsuke Mie
2022-12-27 7:04 ` Michael S. Tsirkin
2022-12-27 7:49 ` Shunsuke Mie
2022-12-27 10:22 ` Shunsuke Mie
2022-12-27 14:37 ` Michael S. Tsirkin
2022-12-28 2:24 ` Shunsuke Mie
2022-12-28 7:20 ` Michael S. Tsirkin
2023-01-11 4:10 ` Shunsuke Mie
2022-12-27 2:25 ` [RFC PATCH 5/9] tools/virtio: convert to use new unified vringh APIs Shunsuke Mie
2022-12-27 2:25 ` Shunsuke Mie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221227022528.609839-7-mie@igel.co.jp \
--to=mie@igel.co.jp \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox