From: Christoph Hellwig <hch@lst.de>
To: Anthony Krowiak <akrowiak@linux.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
Alex Williamson <alex.williamson@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] vfio-mdev: allow building the samples into the kernel
Date: Tue, 10 Jan 2023 16:27:22 +0100 [thread overview]
Message-ID: <20230110152722.GB9485@lst.de> (raw)
In-Reply-To: <b317380e-26bf-b478-4aea-0355e0de4017@linux.ibm.com>
On Tue, Jan 10, 2023 at 09:54:51AM -0500, Anthony Krowiak wrote:
>> + tristate "Build VFIO mtty example mediated device sample code"
>> + depends on VFIO_MDEV
>
>
> Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated,
> "VFIO_MDEV is just a library with helpers for the drivers. Stop making it a
> user choice and just select it by the drivers that use the helpers". Why
> are you not selecting it here?
Because this changes one thing at a time. Patch 2 then switches this
depends to a select.
next prev parent reply other threads:[~2023-01-10 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 9:10 misc mdev tidyups Christoph Hellwig
2023-01-10 9:10 ` [PATCH 1/4] vfio-mdev: allow building the samples into the kernel Christoph Hellwig
2023-01-10 14:54 ` Anthony Krowiak
2023-01-10 15:27 ` Christoph Hellwig [this message]
2023-01-10 15:32 ` Anthony Krowiak
2023-01-10 16:11 ` Jason Gunthorpe
2023-01-10 9:10 ` [PATCH 2/4] vfio-mdev: turn VFIO_MDEV into a selectable symbol Christoph Hellwig
2023-01-10 14:51 ` Anthony Krowiak
2023-01-10 16:12 ` Jason Gunthorpe
2023-01-10 9:10 ` [PATCH 3/4] vfio-mdev: move the mtty usage documentation Christoph Hellwig
2023-01-10 16:12 ` Jason Gunthorpe
2023-01-10 9:10 ` [PATCH 4/4] vfio-mdev: remove an non-existing driver from vfio-mediated-device Christoph Hellwig
2023-01-10 14:49 ` Anthony Krowiak
2023-01-10 16:13 ` Jason Gunthorpe
2023-01-23 19:37 ` misc mdev tidyups Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110152722.GB9485@lst.de \
--to=hch@lst.de \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox