From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC960C54EBE for ; Thu, 12 Jan 2023 17:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233363AbjALRyI (ORCPT ); Thu, 12 Jan 2023 12:54:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232283AbjALRxZ (ORCPT ); Thu, 12 Jan 2023 12:53:25 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D49673E35; Thu, 12 Jan 2023 09:14:10 -0800 (PST) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30CGR7Jk020318; Thu, 12 Jan 2023 17:14:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=HrLVs3x/9vRiPHmPMLnQ2UJ+FGENYqod6FXEc2OLUIQ=; b=B8+MuJClR07bOLpIBiYfk6zsL75wI4HnSIj20ILNRyFfoUvEM7PfPf4/Lxl9b4+wW0IF oh/zsTswzZVryAtQNMwznZrN1d9w249NIoeOiuucWzSta4Y536++r2G0TyOY+KMw5Nt/ kv5U4AYNGP+NWejVm+dTF6H26PjU19FtKXOgH83qY0vd3s5OxSmG553LUoKfx58BoR42 U6Jy7O4UCoHgf5CEXChuHCmi7amoX4an7S3/JTCSBPTom9qEHI5HP8dMMlA2arJ7dDYm lzu0rLG4TENuSbSXGAcRz+ULKOT4LZtzYNuwUG82KIGBQJbGEnGwY0SGuBaiMawRANKd 0w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3n2nr3h59d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jan 2023 17:14:09 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 30CGRgj1021438; Thu, 12 Jan 2023 17:14:09 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3n2nr3h58g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jan 2023 17:14:09 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30CCjG7O001475; Thu, 12 Jan 2023 17:14:07 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma01fra.de.ibm.com (PPS) with ESMTPS id 3n1kmrt241-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jan 2023 17:14:07 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30CHE3Or25035352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Jan 2023 17:14:03 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1B282004E; Thu, 12 Jan 2023 17:14:03 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 800CD2004D; Thu, 12 Jan 2023 17:14:03 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.56]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 12 Jan 2023 17:14:03 +0000 (GMT) Date: Thu, 12 Jan 2023 18:13:53 +0100 From: Claudio Imbrenda To: Janosch Frank Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, thuth@redhat.com, david@redhat.com, nsg@linux.ibm.com, nrb@linux.ibm.com Subject: Re: [kvm-unit-tests PATCH v2 7/7] lib: s390x: Handle debug prints for SIE exceptions correctly Message-ID: <20230112181353.0ed31250@p-imbrenda> In-Reply-To: <20230112154548.163021-8-frankja@linux.ibm.com> References: <20230112154548.163021-1-frankja@linux.ibm.com> <20230112154548.163021-8-frankja@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: XEQ8OtVwV-yNJLKf3JA1Wxdn_bEryM9s X-Proofpoint-GUID: wJZrF-El_RcjTR2__s-gOYqjOAGWo4ty X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-12_08,2023-01-12_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 malwarescore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301120124 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 12 Jan 2023 15:45:48 +0000 Janosch Frank wrote: > When we leave SIE due to an exception, we'll still have guest values > in registers 0 - 13 and that's not clearly portraied in our debug > prints. So let's fix that. > > Signed-off-by: Janosch Frank > --- > lib/s390x/interrupt.c | 46 ++++++++++++++++++++++++++++++++++++++----- > lib/s390x/sie.h | 2 ++ > s390x/cpu.S | 6 ++++-- > 3 files changed, 47 insertions(+), 7 deletions(-) > > diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c > index dadb7415..ff47c2c2 100644 > --- a/lib/s390x/interrupt.c > +++ b/lib/s390x/interrupt.c > @@ -9,6 +9,7 @@ > */ > #include > #include > +#include > #include > #include > #include > @@ -188,9 +189,12 @@ static void print_storage_exception_information(void) > } > } > > -static void print_int_regs(struct stack_frame_int *stack) > +static void print_int_regs(struct stack_frame_int *stack, bool sie) > { > + struct kvm_s390_sie_block *sblk; > + > printf("\n"); > + printf("%s\n", sie ? "Guest registers:" : "Host registers:"); > printf("GPRS:\n"); > printf("%016lx %016lx %016lx %016lx\n", > stack->grs1[0], stack->grs1[1], stack->grs0[0], stack->grs0[1]); > @@ -198,24 +202,56 @@ static void print_int_regs(struct stack_frame_int *stack) > stack->grs0[2], stack->grs0[3], stack->grs0[4], stack->grs0[5]); > printf("%016lx %016lx %016lx %016lx\n", > stack->grs0[6], stack->grs0[7], stack->grs0[8], stack->grs0[9]); > - printf("%016lx %016lx %016lx %016lx\n", > - stack->grs0[10], stack->grs0[11], stack->grs0[12], stack->grs0[13]); > + > + if (sie) { > + sblk = (struct kvm_s390_sie_block *)stack->grs0[12]; > + printf("%016lx %016lx %016lx %016lx\n", > + stack->grs0[10], stack->grs0[11], sblk->gg14, sblk->gg15); > + } else { > + printf("%016lx %016lx %016lx %016lx\n", > + stack->grs0[10], stack->grs0[11], stack->grs0[12], stack->grs0[13]); > + } > + > printf("\n"); > } > > static void print_pgm_info(struct stack_frame_int *stack) > > { > - bool in_sie; > + bool in_sie, in_sie_gregs; > + struct vm_save_area *vregs; > > in_sie = (lowcore.pgm_old_psw.addr >= (uintptr_t)sie_entry && > lowcore.pgm_old_psw.addr <= (uintptr_t)sie_exit); > + in_sie_gregs = (lowcore.pgm_old_psw.addr >= (uintptr_t)sie_entry_gregs && > + lowcore.pgm_old_psw.addr <= (uintptr_t)sie_exit_gregs); can you explain why <= instead of < ? (I think I know why, but a comment would not hurt) with that fixed: Reviewed-by: Claudio Imbrenda > > printf("\n"); > printf("Unexpected program interrupt %s: %#x on cpu %d at %#lx, ilen %d\n", > in_sie ? "in SIE" : "", > lowcore.pgm_int_code, stap(), lowcore.pgm_old_psw.addr, lowcore.pgm_int_id); > - print_int_regs(stack); > + > + /* > + * If we fall out of SIE before loading the host registers, > + * then we need to do it here so we print the host registers > + * and not the guest registers. > + * > + * Back tracing is actually not a problem since SIE restores gr15. > + */ > + if (in_sie_gregs) { > + print_int_regs(stack, true); > + vregs = *((struct vm_save_area **)(stack->grs0[13] + __SF_SIE_SAVEAREA)); > + > + /* > + * The grs are not linear on the interrupt stack frame. > + * We copy 0 and 1 here and 2 - 15 with the memcopy below. > + */ > + stack->grs1[0] = vregs->host.grs[0]; > + stack->grs1[1] = vregs->host.grs[1]; > + /* 2 - 15 */ > + memcpy(stack->grs0, &vregs->host.grs[2], sizeof(stack->grs0) - 8); > + } > + print_int_regs(stack, false); > dump_stack(); > > /* Dump stack doesn't end with a \n so we add it here instead */ > diff --git a/lib/s390x/sie.h b/lib/s390x/sie.h > index a27a8401..147cb0f2 100644 > --- a/lib/s390x/sie.h > +++ b/lib/s390x/sie.h > @@ -273,6 +273,8 @@ struct vm { > > extern void sie_entry(void); > extern void sie_exit(void); > +extern void sie_entry_gregs(void); > +extern void sie_exit_gregs(void); > extern void sie64a(struct kvm_s390_sie_block *sblk, struct vm_save_area *save_area); > void sie(struct vm *vm); > void sie_expect_validity(struct vm *vm); > diff --git a/s390x/cpu.S b/s390x/cpu.S > index 45bd551a..9155b044 100644 > --- a/s390x/cpu.S > +++ b/s390x/cpu.S > @@ -82,7 +82,8 @@ sie64a: > # Store scb and save_area pointer into stack frame > stg %r2,__SF_SIE_CONTROL(%r15) # save control block pointer > stg %r3,__SF_SIE_SAVEAREA(%r15) # save guest register save area > - > +.globl sie_entry_gregs > +sie_entry_gregs: > # Load guest's gprs, fprs and fpc > .irp i, 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15 > ld \i, \i * 8 + SIE_SAVEAREA_GUEST_FPRS(%r3) > @@ -121,7 +122,8 @@ sie_exit: > .endr > lfpc SIE_SAVEAREA_HOST_FPC(%r14) > lmg %r0,%r14,SIE_SAVEAREA_HOST_GRS(%r14) # restore kernel registers > - > +.globl sie_exit_gregs > +sie_exit_gregs: > br %r14 > > .align 8