Re: [RFC PATCH v6 1/6] KVM: x86: only allow exits disable before vCPUs created

Greg KH
2023-01-21T07:28:10Z

On Sat, Jan 21, 2023 at 02:07:33AM +0000, Kechen Lu wrote:
> From: Sean Christopherson <seanjc@google.com>
>
> Since VMX and SVM both would never update the control bits if exits
> are disable after vCPUs are created, only allow setting exits
> disable flag before vCPU creation.
>
> Fixes: 4d5422cea3b6 ("KVM: X86: Provide a capability to disable MWAIT intercepts")
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Nit, no blank line between fixes and signed-off-by please.

And an RFC on v6? An RFC usually means "I don't think this is correct
so do not take it". How can you do that for 6 versions? And know that
no one will take an RFC series for that reason (or at least I will
not...)

thanks,

greg k-h